Qbytearray easy question

[arturs]

Hi

I have the following problem:

QByteArray test;
    test[0]= 0xAB;
    test[1]= 0xCD;
    test[2]= 0xEF;
    test[3]= 0x01;
    test[4]= 0x02;
    test[5]= 0x03;
    test[6]= 0x04;
 
qDebug () << test.at(0);

QByteArray test;
    test[0]= 0xAB;
    test[1]= 0xCD;
    test[2]= 0xEF;
    test[3]= 0x01;
    test[4]= 0x02;
    test[5]= 0x03;
    test[6]= 0x04;

qDebug () << test.at(0);

To copy to clipboard, switch view to plain text mode 

test.at(0) gives me QChar but I need to display Hex Value

for at(0) is diplayed « instead of 0xAB

How to display hex value ?

Regards
Artur

[ChrisW67]

QByteArray::toHex() to convert the whole array.
QByteArray::number(value, 16) to do a single byte (Or QString::number(), QString::arg() etc)

[arturs]

Thank you for help

It works.

qDebug() << QByteArray::number(test.at(0),16);

[Zlatomir]

QDebug supports QTextStream's manipulators, so use the hex manipulator and maybe you need to cast the char to an int:

qDebug() << hex << (int)test.at(0);

qDebug() << hex << (int)test.at(0);

To copy to clipboard, switch view to plain text mode 

[arturs]

something is still wrong ( I make a mistake)

In my case

QByteArray test;
        test[0]= 0xAB;
        test[1]= 0xCD;
        test[2]= 0xEF;
        test[3]= 0x01;
        test[4]= 0x02;
        test[5]= 0x03;
        test[6]= 0x04;
 
        for (int m=0;m<7;m++) qDebug() <<  QByteArray::number(test.at(m),16);

QByteArray test;
        test[0]= 0xAB;
        test[1]= 0xCD;
        test[2]= 0xEF;
        test[3]= 0x01;
        test[4]= 0x02;
        test[5]= 0x03;
        test[6]= 0x04;

        for (int m=0;m<7;m++) qDebug() <<  QByteArray::number(test.at(m),16);

To copy to clipboard, switch view to plain text mode 

The result is :

"ffffffab"
"ffffffcd"
"ffffffef"
"1"
"2"
"3"
"4"

I do not know why. It would be great to display "01" instead of "1".

[Zlatomir]

Note that QByteArray is using a signed char* buffer, so you get a truncation for 0xAB and so on (max value is 127, hex 0x7F).

As for your second question, use QString and arg:

for (int m=0;m<7;m++)
        qDebug() << hex << QString("%0").arg(test.at(m), 2, 16, QChar('0'));

for (int m=0;m<7;m++)
        qDebug() << hex << QString("%0").arg(test.at(m), 2, 16, QChar('0'));

To copy to clipboard, switch view to plain text mode 

[arturs]

How to convert signed byte to unsigned? I receive information from serial port and it is unsigned information.

Regards
Artur

[ChrisW67]

The each signed char (a byte) in the array can hold a signed decimal value between -128 and 127. The hex representation of the bits in the byte has no sign, so:

QByteArray b = "\x7f\xab\xff";
qDebug() << b.toHex();

QByteArray b = "\x7f\xab\xff";
qDebug() << b.toHex();

To copy to clipboard, switch view to plain text mode 

Prints "7fabff" as you expect given what we put in the array

// first the signed interpretation of each byte 
foreach (char sc, b)  {
    qDebug() << QByteArray::number(sc) << QByteArray::number(sc, 16);
}

// first the signed interpretation of each byte 
foreach (char sc, b)  {
    qDebug() << QByteArray::number(sc) << QByteArray::number(sc, 16);
}

To copy to clipboard, switch view to plain text mode 

"127" "7f"
"-85" "ffffffffffffffab"
"-1" "ffffffffffffffff"

"127" "7f"
"-85" "ffffffffffffffab"
"-1" "ffffffffffffffff"

To copy to clipboard, switch view to plain text mode 

The extended hex of the negative numbers is the result of sign extension to a 64-bit int as argument to number().

// and the unsigned version
foreach (char sc, b) {
    unsigned char uc = static_cast<unsigned char>(sc);
    qDebug() << QByteArray::number(uc) << QByteArray::number(uc, 16);
}

// and the unsigned version
foreach (char sc, b) {
    unsigned char uc = static_cast<unsigned char>(sc);
    qDebug() << QByteArray::number(uc) << QByteArray::number(uc, 16);
}

To copy to clipboard, switch view to plain text mode 

"127" "7f"
"171" "ab"
"255" "ff"

"127" "7f"
"171" "ab"
"255" "ff"

To copy to clipboard, switch view to plain text mode 

You see the same bit pattern being interpreted in two different ways through the static_cast.

[Radek]

QByteArray::at() or QByteArray[] is a char - not a QChar. The QChar is a result of a conversion made by qDebug(). If you know the size of the QByteArray, then

const unsigned char *pdata = reinterpret_cast<const unsigned char *>(thearray.constData());

const unsigned char *pdata = reinterpret_cast<const unsigned char *>(thearray.constData());

To copy to clipboard, switch view to plain text mode 

gives you a pointer to binary data in the QByteArray. The casting is necessary to get rid of signed values (see above, where 0xA0 was output as 0xFFA0, etc.) Now, you can, for example:

qDebug << pdata[i];

qDebug << pdata[i];

To copy to clipboard, switch view to plain text mode 

or convert to int by simple assigning:

int val = pdata[i];          // no sign extension

int val = pdata[i];          // no sign extension

To copy to clipboard, switch view to plain text mode 

[arturs]

Could you write me proper code for my code

QByteArray test ;
   test[0] = 0xFF;
  unsigned char ch = 0;
 
   ch = 0xff;
   if (test.at(0)==ch) qDebug () << "OK";
 
   qDebug () << ch;
 
   qDebug () << test.at(0);

QByteArray test ;
   test[0] = 0xFF;
  unsigned char ch = 0;

   ch = 0xff;
   if (test.at(0)==ch) qDebug () << "OK";

   qDebug () << ch;

   qDebug () << test.at(0);

To copy to clipboard, switch view to plain text mode 

because test[0] is signed and ch is unsigned the condition is false. I will try to use your method but without success.

[Radek]

Try

if( (unsigned char)(test.at(0)) == ch ) qDebug() << "OK";

if( (unsigned char)(test.at(0)) == ch ) qDebug() << "OK";

To copy to clipboard, switch view to plain text mode 

[arturs]

It works perfectly :

Thank you for help

[arturs]

I have additional qestion

QByteArray test;
        test[0]= 0xAB;
        test[1]= 0xCD;
        test[2]= 0xEF;
        test[3]= 0x01;
        test[4]= 0x02;
        test[5]= 0x03;
        test[6]= 0x04;

QByteArray test;
        test[0]= 0xAB;
        test[1]= 0xCD;
        test[2]= 0xEF;
        test[3]= 0x01;
        test[4]= 0x02;
        test[5]= 0x03;
        test[6]= 0x04;

To copy to clipboard, switch view to plain text mode 

I need to take only the following bytes
test[1]= 0xCD;
test[2]= 0xEF;
test[4]= 0x02;
test[5]= 0x03;

and show it as a single number

0xCDEF0203 = 3454992899

I try to use the code but it does not work

usnigned long num;
num |= (unsigned char)(test[1]) << 8;
num |= (unsigned char)(test[2]) << 8;
num |= (unsigned char)(test[4]) << 8;
num |= (unsigned char)(test[5]) << 8  ;

usnigned long num;
num |= (unsigned char)(test[1]) << 8;
num |= (unsigned char)(test[2]) << 8;
num |= (unsigned char)(test[4]) << 8;
num |= (unsigned char)(test[5]) << 8  ;

To copy to clipboard, switch view to plain text mode 

Why it does not work ? Maybe is it easier method to do it ?

Regards
Artur

[ars]

First, in your code the variable num is not initialized before you apply operator |= to it. Second, you shift each of the test[] values by 8 bit and combine the shifted value into num. What you need to do is: initialize num to test[1]. Before adding test[2], shift num by 8 bit and then add test[2]. Same procedure for test[4] and test[5]. It may look like

unsigned long num       = (unsigned char)(test[1]) ;
num = num << 8; num |= (unsigned char)(test[2]) ;
num = num << 8; num |= (unsigned char)(test[4]) ;
num = num << 8; num |= (unsigned char)(test[5]) ;

unsigned long num       = (unsigned char)(test[1]) ;
num = num << 8; num |= (unsigned char)(test[2]) ;
num = num << 8; num |= (unsigned char)(test[4]) ;
num = num << 8; num |= (unsigned char)(test[5]) ;

To copy to clipboard, switch view to plain text mode 

[arturs]

Yes. It works.

I have last question.

How to convert my QbyteArray test to QString ?

Regards
Artur

[ars]

See the constructors for QString (http://doc.qt.io/qt-4.8/qstring.html). You can do

QString s(test);

QString s(test);

To copy to clipboard, switch view to plain text mode 

to initalize QString s from QByteArray test. From the documentation:

QString::QString(const QByteArray & ba)

Constructs a string initialized with the byte array ba. The given byte array is converted to Unicode using fromAscii(). Stops copying at the first 0 character, otherwise copies the entire byte array.

You can disable this constructor by defining QT_NO_CAST_FROM_ASCII when you compile your applications. This can be useful if you want to ensure that all user-visible strings go through QObject::tr(), for example.

[Radek]

Please check the Qt classes reference before posting on the forum.

The wanted QString is produced by "fromXXX" static members of QString. If the QByteArray contains UTF8 data (as a byte array) then

QString test2str = QString::fromUtf8(test);

QString test2str = QString::fromUtf8(test);

To copy to clipboard, switch view to plain text mode 

There are more "fromXXX" functions defined in QString.