Custom proxy model issue

[Khal Drogo]

Yes, it does, so here it is:

bool AdvancedSortFilterProxyModel::filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const
{
	bool accept = true;
	const QList<Filter>& andList = m_currentFilter.andList();
	const QList<Filter>& orList = m_currentFilter.orList();
	QList<Filter>::const_iterator it;
	QModelIndex index;
 
	for (it = andList.begin(); it != andList.end(); it++)
	{
		index = sourceModel()->index(sourceRow, (*it).m_column, sourceParent);
		switch ((*it).m_action)
		{
		case FilterAction_Has:
			if (sourceModel()->data(index).toString().contains((*it).m_value) == false)
				accept = false;
			break;
		case FilterAction_Is:
			if ((sourceModel()->data(index).toString() == (*it).m_value.pattern()) == false)
				accept = false;
			break;
		case FilterAction_LessThan:
			if ((sourceModel()->data(index).toDouble() < (*it).m_value.pattern().toDouble()) == false)
				accept = false;
			break;
		case FilterAction_MoreThan:
			if ((sourceModel()->data(index).toDouble() > (*it).m_value.pattern().toDouble()) == false)
				accept = false;
			break;
		default:
			break;
		}
	}
 
	for (it = orList.begin(); it != orList.end(); it++)
	{
		index = sourceModel()->index(sourceRow, (*it).m_column, sourceParent);
		switch ((*it).m_action)
		{
		case FilterAction_Has:
			if (sourceModel()->data(index).toString().contains((*it).m_value))
				accept = true;
			break;
		case FilterAction_Is:
			if ((sourceModel()->data(index).toString() == (*it).m_value.pattern()))
				accept = true;
			break;
		case FilterAction_LessThan:
			if ((sourceModel()->data(index).toDouble() < (*it).m_value.pattern().toDouble()))
				accept = true;
			break;
		case FilterAction_MoreThan:
			if ((sourceModel()->data(index).toDouble() > (*it).m_value.pattern().toDouble()))
				accept = true;
			break;
		default:
			break;
		}
	}
	return accept;
}

bool AdvancedSortFilterProxyModel::filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const
{
	bool accept = true;
	const QList<Filter>& andList = m_currentFilter.andList();
	const QList<Filter>& orList = m_currentFilter.orList();
	QList<Filter>::const_iterator it;
	QModelIndex index;

	for (it = andList.begin(); it != andList.end(); it++)
	{
		index = sourceModel()->index(sourceRow, (*it).m_column, sourceParent);
		switch ((*it).m_action)
		{
		case FilterAction_Has:
			if (sourceModel()->data(index).toString().contains((*it).m_value) == false)
				accept = false;
			break;
		case FilterAction_Is:
			if ((sourceModel()->data(index).toString() == (*it).m_value.pattern()) == false)
				accept = false;
			break;
		case FilterAction_LessThan:
			if ((sourceModel()->data(index).toDouble() < (*it).m_value.pattern().toDouble()) == false)
				accept = false;
			break;
		case FilterAction_MoreThan:
			if ((sourceModel()->data(index).toDouble() > (*it).m_value.pattern().toDouble()) == false)
				accept = false;
			break;
		default:
			break;
		}
	}

	for (it = orList.begin(); it != orList.end(); it++)
	{
		index = sourceModel()->index(sourceRow, (*it).m_column, sourceParent);
		switch ((*it).m_action)
		{
		case FilterAction_Has:
			if (sourceModel()->data(index).toString().contains((*it).m_value))
				accept = true;
			break;
		case FilterAction_Is:
			if ((sourceModel()->data(index).toString() == (*it).m_value.pattern()))
				accept = true;
			break;
		case FilterAction_LessThan:
			if ((sourceModel()->data(index).toDouble() < (*it).m_value.pattern().toDouble()))
				accept = true;
			break;
		case FilterAction_MoreThan:
			if ((sourceModel()->data(index).toDouble() > (*it).m_value.pattern().toDouble()))
				accept = true;
			break;
		default:
			break;
		}
	}
	return accept;
}

To copy to clipboard, switch view to plain text mode 

I know it could be better, i.e. to use QString in the filter and convert it to QRegExp if needed, not the other way around, also, the if's themselves are not quite needed.
But i don't really see, what can cause that behaviour that i described previously...

[Khal Drogo]

Any ideas fresh in the morning perhaps?

[wysota]

The code seems ok, provided those two for loops work as you expect them to work. Which version of Qt are you using? I remember there were some issues about missing items related to the proxy back around Qt 4.2.

BTW. Your and-or mechanism is a bit ambigous. Does X and Y or Z mean (X and Y) or Z or X and (Y or Z)? Because you can only represent the first one using your approach. Storing everything in a tree-like structure would be more flexible. You could then even mix ands and ors - (A and (B or C)) or (D and E).

[Khal Drogo]

I am using 4.3.2.

( About the implementation, you are absolutely right. Using a tree with and/or as nodes and the filters themselves as leaves, then using inorder traversing to interpret the advanced filter would be a much better approach, and one i will definitely consider.

However, sadly, i dont think this influences the problem which i described. )

[wysota]

I suggest you insert some qDebug() statements here and there and use them to pinpoint what exactly happens. If you know what happens, it'll be easier to find a solution.

[Khal Drogo]

I will most certainly try Wysota, though i dont really know what to watch out for.

Thanks for your assistance, i appreciate it.