QString display error

[Devoraz]

is there anything wrong with the following code? how come the %s display a square insstead of the word i want??

if (nodeData.addr==1)
	 {
		nodeName = "room";
	 }
	 else if (nodeData.addr==2)
	 {
		nodeName = "bed";
	 }
	 else if (nodeData.addr==3)
	 {
		nodeName = "kitchen";
	 }
	 else
	 {
	 nodeName = "End Device";
	 }
 
	if (nodeData.addr==0)					//node 0 
	{
		// Write node number
		//qsTemp.sprintf("Node: %d", nodeData.addr);
		qsTemp.sprintf("Access Point");
		//xpainter->setFont(addrFont);
		painter->setFont(timeFont);
		painter->drawText(-50,-15,100,20,Qt::AlignCenter , qsTemp,0);
	}
    else
	{
		// Write node number
		 qsTemp.sprintf("%s %d" ,nodeName, nodeData.addr );
		//xpainter->setFont(addrFont);
		painter->setFont(timeFont);
		painter->drawText(-50,-22,100,20,Qt::AlignCenter , qsTemp,0);
	}

if (nodeData.addr==1)
	 {
		nodeName = "room";
	 }
	 else if (nodeData.addr==2)
	 {
		nodeName = "bed";
	 }
	 else if (nodeData.addr==3)
	 {
		nodeName = "kitchen";
	 }
	 else
	 {
	 nodeName = "End Device";
	 }

	if (nodeData.addr==0)					//node 0 
	{
		// Write node number
		//qsTemp.sprintf("Node: %d", nodeData.addr);
		qsTemp.sprintf("Access Point");
		//xpainter->setFont(addrFont);
		painter->setFont(timeFont);
		painter->drawText(-50,-15,100,20,Qt::AlignCenter , qsTemp,0);
	}
    else
	{
		// Write node number
		 qsTemp.sprintf("%s %d" ,nodeName, nodeData.addr );
		//xpainter->setFont(addrFont);
		painter->setFont(timeFont);
		painter->drawText(-50,-22,100,20,Qt::AlignCenter , qsTemp,0);
	}

To copy to clipboard, switch view to plain text mode 

[yogeshgokul]

Use this instead.

QString::arg

Exmaple:

QString i;           // current file's number
QString total;       // number of files to process
QString fileName;    // current file's name
QString status = QString("Processing file %1 of %2: %3")
                     .arg(i).arg(total).arg(fileName);

QString i;           // current file's number
QString total;       // number of files to process
QString fileName;    // current file's name
QString status = QString("Processing file %1 of %2: %3")
                     .arg(i).arg(total).arg(fileName);

To copy to clipboard, switch view to plain text mode 

[Devoraz]

Use this instead.


Exmaple:

QString i;           // current file's number
QString total;       // number of files to process
QString fileName;    // current file's name
QString status = QString("Processing file %1 of %2: %3")
                     .arg(i).arg(total).arg(fileName);

QString i;           // current file's number
QString total;       // number of files to process
QString fileName;    // current file's name
QString status = QString("Processing file %1 of %2: %3")
                     .arg(i).arg(total).arg(fileName);

To copy to clipboard, switch view to plain text mode 

i dun see how can qstring::arg applied to my code..

[yogeshgokul]

i dun see how can qstring::arg applied to my code..

Replace sprintf with QString::arg.

[wagmare]

else
    {
        // Write node number
         qsTemp.sprintf("%s %d" ,nodeName, nodeData.addr );
        //xpainter->setFont(addrFont);
        painter->setFont(timeFont);
        painter->drawText(-50,-22,100,20,Qt::AlignCenter , qsTemp,0);
    }

else
    {
        // Write node number
         qsTemp.sprintf("%s %d" ,nodeName, nodeData.addr );
        //xpainter->setFont(addrFont);
        painter->setFont(timeFont);
        painter->drawText(-50,-22,100,20,Qt::AlignCenter , qsTemp,0);
    }

To copy to clipboard, switch view to plain text mode 

this can be like this

QString value = QString("Name:%1 and Address:%2").arg(nodeName).arg(QString::number(nodeData.addr, 16));
painter->drawText(-50,-22,100,20,Qt::AlignCenter , value,0);

QString value = QString("Name:%1 and Address:%2").arg(nodeName).arg(QString::number(nodeData.addr, 16));
painter->drawText(-50,-22,100,20,Qt::AlignCenter , value,0);

To copy to clipboard, switch view to plain text mode 

[Devoraz]

Replace sprintf with QString::arg.

if (nodeData.addr==1)
	 {
		nodeName = "room";
	 }
	 else if (nodeData.addr==2)
	 {
		nodeName = "bed";
	 }
	 else if (nodeData.addr==3)
	 {
		nodeName = "kitchen";
	 }
	 else
	 {
	 nodeName = "End Device";
	 }

if (nodeData.addr==1)
	 {
		nodeName = "room";
	 }
	 else if (nodeData.addr==2)
	 {
		nodeName = "bed";
	 }
	 else if (nodeData.addr==3)
	 {
		nodeName = "kitchen";
	 }
	 else
	 {
	 nodeName = "End Device";
	 }

To copy to clipboard, switch view to plain text mode 

the if else statement share the same variable QString nodeName, u sure the %1 can work? i tried it cant work.

[Devoraz]

else
    {
        // Write node number
         qsTemp.sprintf("%s %d" ,nodeName, nodeData.addr );
        //xpainter->setFont(addrFont);
        painter->setFont(timeFont);
        painter->drawText(-50,-22,100,20,Qt::AlignCenter , qsTemp,0);
    }

else
    {
        // Write node number
         qsTemp.sprintf("%s %d" ,nodeName, nodeData.addr );
        //xpainter->setFont(addrFont);
        painter->setFont(timeFont);
        painter->drawText(-50,-22,100,20,Qt::AlignCenter , qsTemp,0);
    }

To copy to clipboard, switch view to plain text mode 

this can be like this

QString value = QString("Name:%1 and Address:%2").arg(nodeName).arg(QString::number(nodeData.addr, 16));
painter->drawText(-50,-22,100,20,Qt::AlignCenter , value,0);

QString value = QString("Name:%1 and Address:%2").arg(nodeName).arg(QString::number(nodeData.addr, 16));
painter->drawText(-50,-22,100,20,Qt::AlignCenter , value,0);

To copy to clipboard, switch view to plain text mode 

OMG~ it works. thanks!! my code work as well.

QString value = QString("%1 %2").arg(nodeName).arg(nodeData.addr);
		painter->setFont(timeFont);
		painter->drawText(-50,-22,100,20,Qt::AlignCenter , value,0);

QString value = QString("%1 %2").arg(nodeName).arg(nodeData.addr);
		painter->setFont(timeFont);
		painter->drawText(-50,-22,100,20,Qt::AlignCenter , value,0);

To copy to clipboard, switch view to plain text mode