Segmentation fault when creating new QString

[di_zou]

I have:

//Node.cpp
 
#include "Node.h"
 
Node::Node(QWidget *parent)
	: QLabel (parent) {
}
 
void Node::setName(string picName) {
	nodePicName = new QString(QString::fromStdString(picName));
}

//Node.cpp

#include "Node.h"

Node::Node(QWidget *parent)
	: QLabel (parent) {
}

void Node::setName(string picName) {
	nodePicName = new QString(QString::fromStdString(picName));
}

To copy to clipboard, switch view to plain text mode 

and then in my "Node.h" file I have:

class Node : public QLabel {
 
	Q_OBJECT
 
public:
	Node(QWidget *parent = 0);
	virtual ~Node();
	void setName(string picName);
 
private:
	QString *nodeName;
}:

class Node : public QLabel {

	Q_OBJECT

public:
	Node(QWidget *parent = 0);
	virtual ~Node();
	void setName(string picName);

private:
	QString *nodeName;
}:

To copy to clipboard, switch view to plain text mode 

I am getting a segmentation fault at where I have:

nodePicName = new QString(QString::fromStdString(picName));

nodePicName = new QString(QString::fromStdString(picName));

To copy to clipboard, switch view to plain text mode 

[franz]

I don't know what exactly goes wrong, but why don't you just use

QString nodeName;

QString nodeName;

To copy to clipboard, switch view to plain text mode 

and

void setName(std::string name)
{
    nodeName = QString::fromStdString(name);
}

void setName(std::string name)
{
    nodeName = QString::fromStdString(name);
}

To copy to clipboard, switch view to plain text mode 

or what would have my preference

void SomeClass::setName(const QString &name)
{
    nodeName = name;
}

void SomeClass::setName(const QString &name)
{
    nodeName = name;
}

To copy to clipboard, switch view to plain text mode 

then call the function using

obj.setName(QString::fromStdString(somestring));

obj.setName(QString::fromStdString(somestring));

To copy to clipboard, switch view to plain text mode 

There is no need to use pointers for QStrings since they implement implicit sharing, which basically means that if you copy a string, you only copy a reference to the data. When you start to change the contents, then a deep copy is made. This design approach makes it easier for you to code, less error prone (less memory leaks) and more readable.

[di_zou]

So I changed it around to this:

void Node::setName(const QString &name)
{
    nodeName = name;
}

void Node::setName(const QString &name)
{
    nodeName = name;
}

To copy to clipboard, switch view to plain text mode 

and

class Node : public QLabel {
 
    Q_OBJECT
 
public:
    Node(QWidget *parent = 0);
    virtual ~Node();
    void setName(const QString &name);
 
private:
    QString nodeName;
};

class Node : public QLabel {
 
    Q_OBJECT
 
public:
    Node(QWidget *parent = 0);
    virtual ~Node();
    void setName(const QString &name);
 
private:
    QString nodeName;
};

To copy to clipboard, switch view to plain text mode 

but I still get a seg fault inside the setName method.

[di_zou]

Nvrmnd got it working. Thank you.