pig letin generator readout problems

[Petr_Kropotkin]

I writing a pig latin generator. Some times it prints out the english phrase fine, other times it doesn't
For instance "i want to have fun prints out
iay antway tnoway avehay eunfay
The buffer doesn't empty out after each word.
Help !

Here is my code:

#include <iostream>
#include <cstring>
#include <cstdlib>
 
using namespace std;
 
 int len=0,i;
char postfix[3]="ay";
char tmp[2]="\0";
char word[10]="\0";
 
 void printLatinWord(char *token)
 {
          len=strlen(token);
          //get first char
          strncpy(tmp,token,1);
         ///copy backwards to get string
          strrev(token);
          strncpy(word,token,len-1);
         // reverse it back no we have the string
         strrev(word);
         //add first and postfix;
             cout<<word<tmp<<postfix<"   ";
 
 
}
 
 
int main()
{
 
char *token;
char sentance[50];
cout<<"Enter in English sentance to be translated->";
cin.getline(sentance,50);
 token=strtok(sentance," ");
 while (token != NULL )
 {
     printLatinWord(token);
     token=strtok(NULL, " ");
    }
 
system("Pause");
}

#include <iostream>
#include <cstring>
#include <cstdlib>

using namespace std;

 int len=0,i;
char postfix[3]="ay";
char tmp[2]="\0";
char word[10]="\0";

 void printLatinWord(char *token)
 {
          len=strlen(token);
          //get first char
          strncpy(tmp,token,1);
         ///copy backwards to get string
          strrev(token);
          strncpy(word,token,len-1);
         // reverse it back no we have the string
         strrev(word);
         //add first and postfix;
             cout<<word<tmp<<postfix<"   ";


}


int main()
{

char *token;
char sentance[50];
cout<<"Enter in English sentance to be translated->";
cin.getline(sentance,50);
 token=strtok(sentance," ");
 while (token != NULL )
 {
     printLatinWord(token);
     token=strtok(NULL, " ");
    }

system("Pause");
}

To copy to clipboard, switch view to plain text mode 

[squidge]

strncpy will not include the null terminator if the length specified in the third argument is less than the string given in the second argument. Therefore you words are not null terminated, and will get whatever garbage is there previously. You either need to initialise the array your copying to, or change your algorithm.

[Petr_Kropotkin]

I thought i did initialise the arrays.
I thought it was initiaised to
char postfix[3]="ay";
char tmp[2]="\0";
char word[10]='\0'

if word[10] is not initiaiised how about this strcpy(word, '0');

[squidge]

Consider this:

wordA[8] = 'ABCDEFGH';
wordB[4] = 'WXYZ';
strncpy (wordA, wordB, 4);

wordA[8] = 'ABCDEFGH';
wordB[4] = 'WXYZ';
strncpy (wordA, wordB, 4);

To copy to clipboard, switch view to plain text mode 

wordA now contains: 'WXYZEFGH';
if you want wordA to contain 'WXYZ' you need to do wordA[4] = 0; or strncpy (wordA, wordB, 5);