error message appears when function is called

[babygal]

An error message prompt appears when function, processInputData(param1, param2, ....) is called.
The application exits when 'Don't Send' button on the message prompt is clicked on.
How do I resolve this issue?

Here is the code:

New::New(QWidget *parent) :
    QDialog(parent)
{
    okButton = createButton(tr("&OK"), SLOT(messageOk()));
 
    createCMRFilesMessageGroupBox();
    createEDMessageGroupBox();
    createESMessageGroupBox();
 
    createmainLayout();
 
    setWindowTitle(tr("New Case"));
    resize(450, 100);
}
void New::messageOk()
{
 
    QMessageBox::about(this,tr("OK clicked"),tr("OK"));
    processInputData(endocardialfileName.toAscii(), //convert 'QString' to 'const char*'
                                  epicardialfileName.toAscii(),    //convert 'QString' to 'const char*'
                                  1,
                                  1.1,
                                  1.1,
                                  1,
                                  1.1,
                                  1.1);
 
 
}

New::New(QWidget *parent) :
    QDialog(parent)
{
    okButton = createButton(tr("&OK"), SLOT(messageOk()));

    createCMRFilesMessageGroupBox();
    createEDMessageGroupBox();
    createESMessageGroupBox();
    
    createmainLayout();

    setWindowTitle(tr("New Case"));
    resize(450, 100);
}
void New::messageOk()
{

    QMessageBox::about(this,tr("OK clicked"),tr("OK"));
    processInputData(endocardialfileName.toAscii(), //convert 'QString' to 'const char*'
                                  epicardialfileName.toAscii(),    //convert 'QString' to 'const char*'
                                  1,
                                  1.1,
                                  1.1,
                                  1,
                                  1.1,
                                  1.1);


}

To copy to clipboard, switch view to plain text mode 

Definition of processInputData( ):

processInputData(const char*, const char* ,
                              const int,
                              const float, const float,
                              const int,
                              const float, const float );

processInputData(const char*, const char* ,
                              const int,
                              const float, const float,
                              const int,
                              const float, const float );

To copy to clipboard, switch view to plain text mode 

[ChrisW67]

QString::toAscii() does not return a const char pointer.

[babygal]

How do I resolve the issue?

[babygal]

The error mentioned is as seen in the attachment. How do I resolve it quickly?
I don't get any error when i compile. I am only getting this error during run time...:-(

[agathiyaa]

I cannot read your doc file. I suspect you may do the following which i guess from the previous reply..

pInputdata=QString::toAscii() .data();

I assume char* pInputData is a Function Argument. If this isn't right please show me what is in your error.doc file in plain text. If my assumption is right let me know. the solution is simple.

[babygal]

The error is :
Application.exe has encountered a problem and needs to close. We are sorry for the inconvenience.If you were in the middle of something, the information you were working on might be lost.

Please tell Microsoft about this problem.We have created an error report that you can send to us. We will treat this report as confidential and anonymous. To see what data this error report contains, click here.

[ChrisW67]

You will get this generic catch-all error from the Windows system if you access a pointer that is invalid or you access more memory than you should through an otherwise valid pointer (and any number of other things). If something is expecting a pointer to a NUL terminated string (as your code is) and you pass something that is not a pointer to a NUL terminated string (as your code does) then this is often the result.

You are passing a QByteArray where the code is expecting a const char*. You need to revisit lines 19 and 20 of your original post after reading the docs for QString::toAscii() and QByteArray::constData()

[babygal]

Can you please show me clearly? I don't quite understand.

[babygal]

I cannot read your doc file. I suspect you may do the following which i guess from the previous reply..

pInputdata=QString::toAscii() .data();

I assume char* pInputData is a Function Argument. If this isn't right please show me what is in your error.doc file in plain text. If my assumption is right let me know. the solution is simple.

Can you please show me clearly? I don't quite understand how to implement this way.

[babygal]

I solved the bug with the code below:

1.

processInputData(endocardialfileName.toAscii().constData(),  epicardialfileName.toAscii().constData(), ....

processInputData(endocardialfileName.toAscii().constData(),  epicardialfileName.toAscii().constData(), ....

To copy to clipboard, switch view to plain text mode 

Other 3 possible solutions I found :

2.

processInputData(endocardialfileName.toAscii().data(),  epicardialfileName.toAscii().data(), ....

processInputData(endocardialfileName.toAscii().data(),  epicardialfileName.toAscii().data(), ....

To copy to clipboard, switch view to plain text mode 

3.

processInputData(endocardialfileName.toLatin1().constData(),  epicardialfileName.toLatin1().constData(), ....

processInputData(endocardialfileName.toLatin1().constData(),  epicardialfileName.toLatin1().constData(), ....

To copy to clipboard, switch view to plain text mode 

4.

processInputData(endocardialfileName.toLatin1().data(),  epicardialfileName.toLatin1().data(), ....

processInputData(endocardialfileName.toLatin1().data(),  epicardialfileName.toLatin1().data(), ....

To copy to clipboard, switch view to plain text mode 

[agathiyaa]

Good to know that you have solved the issue.

But my recommendation is to use the following

char end[MAX_PATH]={0};
char epi[MAX_PATH]={0};
 
strcpy(end,endocardialfileName.toAscii().data());
strcpy(epi,epicardialfileName.toAscii().data());
 
processInputData(end,epi,...);

char end[MAX_PATH]={0};
char epi[MAX_PATH]={0};

strcpy(end,endocardialfileName.toAscii().data());
strcpy(epi,epicardialfileName.toAscii().data());

processInputData(end,epi,...);

To copy to clipboard, switch view to plain text mode 

Because toAscii().data() function uses internal stack which may not be valid all the time.

Any Comments ???.

[ChrisW67]

The four options babygal pointed out should be safe because the scope of the temporary QByteArray in the:

processInputData(endocardialfileName.toLatin1().constData(), ...

processInputData(endocardialfileName.toLatin1().constData(), ...

To copy to clipboard, switch view to plain text mode 

call extends to the completion of function processInputData() (the enclosing C++ statement). If the value could not be used immediately then you would have to make a persistent copy of it as above (using strncpy or a safer option though), or by making the QByteArray explicit so that you can control the scope:

{
  ...
  QByteArray asciiFileName = endocardialfileName.toAscii();
  processInputData(asciiFileName.constData(), ...);
  // more uses of the ASCII string
  char *s = asciiFileName.data();
  somefunc(s);
  ...
}

{
  ...
  QByteArray asciiFileName = endocardialfileName.toAscii();
  processInputData(asciiFileName.constData(), ...);
  // more uses of the ASCII string
  char *s = asciiFileName.data();
  somefunc(s);
  ...
}

To copy to clipboard, switch view to plain text mode