QDomNode::replaceChild Question

[Dan Milburn]

The code you have provided does not check the return value of n.replaceChild() at all. It would be more helpful if you could provide the actual code you are using. In any case, you are replacing e2, that is once you've called n.replaceChild(elem, e2); the node referenced by e2 is no longer a child of node n and so continuing to iterate over it will fail. What you probably want is to put e2 = elem; after the replace call.

[KineticArc]

Wow... that was a stupid mistake. It essentially is like a link in a link list. Once you append the element into the list of XML tags, that element becomes the new link in the chain, as the previous element was replaced by the new element. Therefore, the links to the previous and next sibling elements are null pointers. Therefore, by doing the following, I got it to work with your recommendation. (oh, I did have it returning e2 = n.replaceChild(elem, e2), but that was incorrect, as it needs to be the next sibling element. I just didn't have it reflected in the code I posted above, as it was just a way to quickly convey what I was trying to express).

QDomNode n = root.firstChild();
while(!n.isNull())
{
    QDomElement e = n.toElement();
    if(!e.isNull())
    {
        if((e.tagName() == "config") and (e.attribute("name", "") == "Eddie"))
        {
            QDomElement e2 = n.firstChildElement();
            while(!e2.isNull())
            {
                if(e2.tagName() == "execdir")
                {
                    QDomElement elem = doc.createElement("execdir");
                    elem.appendChild(doc.createTextNode("EXECUTABLE DIRECTORY"));
                    e2 = n.replaceChild(elem, e2).nextSiblingElement();
                }
                else if(e2.tagName() == "binary")
                {
                    QDomElement elem = doc.createElement("binary");
                    elem.appendChild(doc.createTextNode("EXECUTABLE"));
                    e2 = n.replaceChild(elem, e2).nextSiblingElement();
                }
                else e2 = e2.nextSiblingElement();
            }
        }
    }
 
    n = n.nextSibling();
}

QDomNode n = root.firstChild();
while(!n.isNull())
{
    QDomElement e = n.toElement();
    if(!e.isNull())
    {
        if((e.tagName() == "config") and (e.attribute("name", "") == "Eddie"))
        {
            QDomElement e2 = n.firstChildElement();
            while(!e2.isNull())
            {
                if(e2.tagName() == "execdir")
                {
                    QDomElement elem = doc.createElement("execdir");
                    elem.appendChild(doc.createTextNode("EXECUTABLE DIRECTORY"));
                    e2 = n.replaceChild(elem, e2).nextSiblingElement();
                }
                else if(e2.tagName() == "binary")
                {
                    QDomElement elem = doc.createElement("binary");
                    elem.appendChild(doc.createTextNode("EXECUTABLE"));
                    e2 = n.replaceChild(elem, e2).nextSiblingElement();
                }
                else e2 = e2.nextSiblingElement();
            }
        }
    }

    n = n.nextSibling();
}

To copy to clipboard, switch view to plain text mode 

That now works, as stated. Just thought I would post the final code for anyone else looking at the same dumb mistake I was making.