Templates and signals

[Ubii]

Hi!

Code:

Header

template <class D>
class Signal
: public QObject
{
public:
void signal(D);
signals:
void send(D);
};

template <class D>
class Signal
: public QObject
{
public:
void signal(D);
signals:
void send(D);
};

To copy to clipboard, switch view to plain text mode 

cpp

template <class D> void Signal<D>::signal(D data)
{
emit send(data);
}

template <class D> void Signal<D>::signal(D data)
{
emit send(data);
}

To copy to clipboard, switch view to plain text mode 

namespace plot{
Signal* xSignal;
}
//------------------------
plot::xSignal = new Signal();
QObject::connect(plot::xSignal, SIGNAL(send(double)), this, SLOT(notImportant(double)));

namespace plot{
Signal* xSignal;
}
//------------------------
plot::xSignal = new Signal();
QObject::connect(plot::xSignal, SIGNAL(send(double)), this, SLOT(notImportant(double)));

To copy to clipboard, switch view to plain text mode 

Everything still works to compile here but in next step something happend

double data = 0;
plot::xSignal->signal(data);

double data = 0;
plot::xSignal->signal(data);

To copy to clipboard, switch view to plain text mode 

This code should send a signal to notImportant() like this:
First to "Signal::signal(double)" which send signal to "Signal::send(double)" which is connected to "notImportant(double)".
But I can't compile when I add the last line I got an error message.
Line:

plot::xSignal->signal(data);

plot::xSignal->signal(data);

To copy to clipboard, switch view to plain text mode 

Error message is:

error: undefined reference to `Signal<double>::signal(double)''

error: undefined reference to `Signal<double>::signal(double)''

To copy to clipboard, switch view to plain text mode 

I am new to templates so it is propably someting wrong there.

Does any of you know whats wrong?

Thanks
Ubi

Sorry for my english, I am from Sweden

[Timoteo]

Did you not mean

plot::xSignal = new Signal<double>();

plot::xSignal = new Signal<double>();

To copy to clipboard, switch view to plain text mode 

instead of

plot::xSignal = new Signal();

plot::xSignal = new Signal();

To copy to clipboard, switch view to plain text mode 

Also where is your constructor for Signal?

[wysota]

Just to warn you - Qt signals/slots mechanism is unable to cooperate with template classes.

[Ubii]

Did you not mean

plot::xSignal = new Signal<double>();

plot::xSignal = new Signal<double>();

To copy to clipboard, switch view to plain text mode 

instead of

plot::xSignal = new Signal();

plot::xSignal = new Signal();

To copy to clipboard, switch view to plain text mode 

Also where is your constructor for Signal?

Yes, somehow chrome removed <double> so I used firefox instead and forgot to add it again.

Just to warn you - Qt signals/slots mechanism is unable to cooperate with template classes.

Thanks for the warning.
Then I do it in some other way

[Timoteo]

As an example of something you could do, I threw together some code real quick. This uses libsigc++.

template<typename rt, typename T> class EmittingObject
{
	std::tr1::shared_ptr<T> t;
	sigc::signal<rt> m_signal;
public:
	EmittingObject()
	{
		t = std::tr1::shared_ptr<T>(new T);
	}	
	sigc::signal<rt>& getSignal() { return m_signal; }
	std::tr1::shared_ptr<T> object() { return t;} 
};

template<typename rt, typename T> class EmittingObject
{
	std::tr1::shared_ptr<T> t;
	sigc::signal<rt> m_signal;
public:
	EmittingObject()
	{
		t = std::tr1::shared_ptr<T>(new T);
	}	
	sigc::signal<rt>& getSignal() { return m_signal; }
	std::tr1::shared_ptr<T> object() { return t;} 
};

To copy to clipboard, switch view to plain text mode 

/*class demonstrating a trivial connection*/
class XWidget : public EmittingObject<void, QWidget>, public sigc::trackable
{
	void handle_signal()
	{
		this->object()->close();		
	}
public:
	XWidget()
	{
		getSignal().connect(sigc::mem_fun(this, &XWidget::handle_signal));
    }
	void doSomethingToCauseAnEmit()
	{		
		if(QMessageBox::question(object().get(), "Hello!", "Keep the widget open?", QMessageBox::Yes | QMessageBox::No) == QMessageBox::No)
			getSignal().emit();
	}
};

/*class demonstrating a trivial connection*/
class XWidget : public EmittingObject<void, QWidget>, public sigc::trackable
{
	void handle_signal()
	{
		this->object()->close();		
	}
public:
	XWidget()
	{
		getSignal().connect(sigc::mem_fun(this, &XWidget::handle_signal));
    }
	void doSomethingToCauseAnEmit()
	{		
		if(QMessageBox::question(object().get(), "Hello!", "Keep the widget open?", QMessageBox::Yes | QMessageBox::No) == QMessageBox::No)
			getSignal().emit();
	}
};

To copy to clipboard, switch view to plain text mode 

/*quick test piece*/
int main(int argc, char* argv[])
{
	QApplication app(argc, argv);	
	XWidget widget;
	widget.object()->show();
	while(widget.object()->isVisible())
	{
		widget.doSomethingToCauseAnEmit();
	}	
	app.exit(0);
}

/*quick test piece*/
int main(int argc, char* argv[])
{
	QApplication app(argc, argv);	
	XWidget widget;
	widget.object()->show();
	while(widget.object()->isVisible())
	{
		widget.doSomethingToCauseAnEmit();
	}	
	app.exit(0);
}

To copy to clipboard, switch view to plain text mode 

Sorry for the poor formatting, but that is Visual Assist's fault.

This is a silly example, I know. The basic concept is to sidestep Qt's signal/slot mechanism and employ another (if you truly need this type of thing, you may not!).

[Ubii]

As an example of something you could do, I threw together some code real quick. This uses libsigc++.

template<typename rt, typename T> class EmittingObject
{
	std::tr1::shared_ptr<T> t;
	sigc::signal<rt> m_signal;
public:
	EmittingObject()
	{
		t = std::tr1::shared_ptr<T>(new T);
	}	
	sigc::signal<rt>& getSignal() { return m_signal; }
	std::tr1::shared_ptr<T> object() { return t;} 
};

template<typename rt, typename T> class EmittingObject
{
	std::tr1::shared_ptr<T> t;
	sigc::signal<rt> m_signal;
public:
	EmittingObject()
	{
		t = std::tr1::shared_ptr<T>(new T);
	}	
	sigc::signal<rt>& getSignal() { return m_signal; }
	std::tr1::shared_ptr<T> object() { return t;} 
};

To copy to clipboard, switch view to plain text mode 

/*class demonstrating a trivial connection*/
class XWidget : public EmittingObject<void, QWidget>, public sigc::trackable
{
	void handle_signal()
	{
		this->object()->close();		
	}
public:
	XWidget()
	{
		getSignal().connect(sigc::mem_fun(this, &XWidget::handle_signal));
    }
	void doSomethingToCauseAnEmit()
	{		
		if(QMessageBox::question(object().get(), "Hello!", "Keep the widget open?", QMessageBox::Yes | QMessageBox::No) == QMessageBox::No)
			getSignal().emit();
	}
};

/*class demonstrating a trivial connection*/
class XWidget : public EmittingObject<void, QWidget>, public sigc::trackable
{
	void handle_signal()
	{
		this->object()->close();		
	}
public:
	XWidget()
	{
		getSignal().connect(sigc::mem_fun(this, &XWidget::handle_signal));
    }
	void doSomethingToCauseAnEmit()
	{		
		if(QMessageBox::question(object().get(), "Hello!", "Keep the widget open?", QMessageBox::Yes | QMessageBox::No) == QMessageBox::No)
			getSignal().emit();
	}
};

To copy to clipboard, switch view to plain text mode 

/*quick test piece*/
int main(int argc, char* argv[])
{
	QApplication app(argc, argv);	
	XWidget widget;
	widget.object()->show();
	while(widget.object()->isVisible())
	{
		widget.doSomethingToCauseAnEmit();
	}	
	app.exit(0);
}

/*quick test piece*/
int main(int argc, char* argv[])
{
	QApplication app(argc, argv);	
	XWidget widget;
	widget.object()->show();
	while(widget.object()->isVisible())
	{
		widget.doSomethingToCauseAnEmit();
	}	
	app.exit(0);
}

To copy to clipboard, switch view to plain text mode 

Sorry for the poor formatting, but that is Visual Assist's fault.

This is a silly example, I know. The basic concept is to sidestep Qt's signal/slot mechanism and employ another (if you truly need this type of thing, you may not!).

Thanks for the example! Taught me a lot!

I'm not sure I will use it in this project though, because I don't really need it.

But I am sure it will be usefull in my other projects!

[Timoteo]

Glad you liked it, but like I said it is not meant to be a great example - just something to show what could be a great alternative if enough time is put into it (and a better design - composition would have been more appropriate than inheritance for example).