Inheritance of a static object factory

[nomiz]

Dear all,

Could someone please explain what I am doing wrong below, and why this is not working?

Thanks!

In a dynamic library i have a class LibObject that has a static function createObject() which returns an instance of itself:

class LibObject
{
    private:
        int a;
 
    public:
        LibObject();
        static LibObject createObject(); // the LibObject factory
        int getA();
        void setA(int i);
}
 
LibOjcect::LibObject() {}
 
LibObject LibObject::createObject() { // the LibObject factory
    LibObject o;
    return o;   
}
 
int LibObject::getA() { return a }
 
void LibObject::setA(int i) { a = i }

class LibObject
{
    private:
        int a;

    public:
        LibObject();
        static LibObject createObject(); // the LibObject factory
        int getA();
        void setA(int i);
}

LibOjcect::LibObject() {}

LibObject LibObject::createObject() { // the LibObject factory
    LibObject o;
    return o;   
}

int LibObject::getA() { return a }

void LibObject::setA(int i) { a = i }

To copy to clipboard, switch view to plain text mode 

Now in another class Object I am extending the LibObjectclass:

class Object : public LibObject
{
  public:
      Object();
}
 
Object::Object() {}

class Object : public LibObject
{
  public:
      Object();
}

Object::Object() {}

To copy to clipboard, switch view to plain text mode 

Ok. So, now a third class would like to add Object objects to a QList:

class Test
{
    private:
        QList<Object> objects;
 
    public:
        Test();
}
 
Test::Test()
{
    objects.append(Object::createObject());
}

class Test
{
    private:
        QList<Object> objects;
    
    public:
        Test();
}

Test::Test()
{
    objects.append(Object::createObject());
}

To copy to clipboard, switch view to plain text mode 

At compile time I get this error:
error: no matching function for call to 'QList<Object>::append(LibObject)'

So, is the static function createObject() not copied to the Object declaration?

[wayfaerer]

Shouldn't that be "QList<LibObject>" in class Test?

[nomiz]

Well, I would like it to be QList<Object>, because I want to add stuff in Object relative to LibObject..

[wayfaerer]

But LibObject::createObject() returns a LibObject, not an Object. You can make it return an Object if you want it to.

[nomiz]

Please explain. Do I have to re-declare the createObject() method in the Object class definition?

[wayfaerer]

I don't think so.

A base class factory method can (and often does) return an instance of a derived class. You would just change LibObject::createObject to:

Object LibObject::createObject() {
    Object o;
    return o;   
}

Object LibObject::createObject() {
    Object o;
    return o;   
}

To copy to clipboard, switch view to plain text mode 

There's an excellent example of something similar here (in the "after" section): http://sourcemaking.com/design_patte...y_method/cpp/1

[nomiz]

No way! But then, shouldn't LibObject (the base class) be aware of its subclass (Object)? I think I don't exactly understand it yet, but I'll read your reference. Thanks!

[wayfaerer]

It blew my mind too.

It should be aware of the subclass, in the sense that it needs to #include the subclass's header file (or they could be in the same header file).

[nomiz]

Cool! I'l try

---

Added after 14 minutes:

Hmm, the LibObstacle class cannot access class Object, because LibObject is a class in a shared library. And class Object resides in another application. What now??

---

Added after 27 minutes:

Maybe I should forget about using the static factory function? I could add a LibObject::setAllAttributes() function and in Test use something like

Test::Test()
{
    Object o;
    o.setAllAttributes();
    objects.append(o);
}

Test::Test()
{
    Object o;
    o.setAllAttributes();
    objects.append(o);
}

To copy to clipboard, switch view to plain text mode 

---

Added after 9 minutes:

Ok, that works. But it is not very elegant. What could be a better solution, still using the factory-pattern?

[ChrisW67]

You are storing actual instances in the list: LibObject and Object are not interchangable. Pointers to LibObjects and Objects could both be stored in a QList<LibObject*> because a base class pointer can point to an instance of a derived class:

#include <QtCore>
#include <QDebug>
 
class LibObject {
public:
  virtual void saySomething() { qDebug() << "LibObject"; }
};
 
class ObjectA: public LibObject {
public:
  virtual void saySomething() { qDebug() << "ObjectA"; }
};
 
class ObjectB: public LibObject {
public:
  virtual void saySomething() { qDebug() << "ObjectB"; }
};
 
class ObjectC: public LibObject {
public:
  virtual void saySomething() { qDebug() << "ObjectC"; }
};
 
// The factory method needs to know about all the classes but returns a pointer to the base class
LibObject *createObject(int type)
{
  switch(type) {
  case 0: return new ObjectA;
  case 1: return new ObjectB;
  case 2: return new ObjectC;
  }
  return 0;
}
 
int main(int argc, char **argv)
{
    QCoreApplication app(argc, argv);
 
    // only need to know that a LibObject class exists to do this
    QList<LibObject *> list;
    list << createObject(0) << createObject(1) << createObject(2);
    foreach(LibObject *o, list)
      o->saySomething();
    qDeleteAll(list);
 
    return 0;
}

#include <QtCore>
#include <QDebug>

class LibObject {
public:
  virtual void saySomething() { qDebug() << "LibObject"; }
};

class ObjectA: public LibObject {
public:
  virtual void saySomething() { qDebug() << "ObjectA"; }
};

class ObjectB: public LibObject {
public:
  virtual void saySomething() { qDebug() << "ObjectB"; }
};

class ObjectC: public LibObject {
public:
  virtual void saySomething() { qDebug() << "ObjectC"; }
};

// The factory method needs to know about all the classes but returns a pointer to the base class
LibObject *createObject(int type)
{
  switch(type) {
  case 0: return new ObjectA;
  case 1: return new ObjectB;
  case 2: return new ObjectC;
  }
  return 0;
}

int main(int argc, char **argv)
{
    QCoreApplication app(argc, argv);

    // only need to know that a LibObject class exists to do this
    QList<LibObject *> list;
    list << createObject(0) << createObject(1) << createObject(2);
    foreach(LibObject *o, list)
      o->saySomething();
    qDeleteAll(list);

    return 0;
}

To copy to clipboard, switch view to plain text mode 

[nomiz]

Alright. Thanks for the explanation Chris!