How to connect to ftp server and read the filenames in the ftp folder?

[mahi6a1985]

yes i agree but i have given the ip address of the other machine in that ftp example i can able to connect it but cant see the files list.

My aim is to connect to a remote system (windows OS) from my Linux system and copy a directory of windows system (i.e., which consists of 2 or 3 text files) to my linux system.

[wysota]

yes i agree but i have given the ip address of the other machine in that ftp example i can able to connect it but cant see the files list.

Maybe it's a matter of being able to perform active/passive FTP connection.

[mahi6a1985]

Maybe it's a matter of being able to perform active/passive FTP connection.

yes you are absolutely correct my ftp server application which in windows wont accept passive FTP connection.
So, i have to make some changes then... ??

Thanks wysota

[wysota]

You have to act accordingly to the protocol approach you wish to support.

[mahi6a1985]

You have to act accordingly to the protocol approach you wish to support.

Hi wysota,

Now i am able to connect to ftp server and can view the entire remote system FTP server files and also i can download them but the problem is some of them were 0-bytes means only file is downloaded non of the content is downloaded and some of them were half downloaded.
But all the files listed in the FTP site were downloaded to my local directory.

what could be the problem ?

i have seen the QFTP example their its only one file at a time so it seems fine. But in my case i want to download all the files of the ftp folder.

[wysota]

And how are you doing that?

[mahi6a1985]

And how are you doing that?

After getting the list using ftp->list();
i am using a loop and calling each of the listed files one by one using ftp->get(urlInfo.name(),file);

[wysota]

Show the actual code, please.

[mahi6a1985]

Show the actual code, please.

localDir = "/home/nn";
        QUrl url("ftp://192.168.1.146");
        ftp->connectToHost(url.host(),url.port(21));
        ftp->login();
    connect(ftp, SIGNAL(commandFinished(int,bool)), this, SLOT(ftpCommandFinished(int,bool)));
    connect(ftp, SIGNAL(listInfo(QUrlInfo)), this, SLOT(ftpListInfo(QUrlInfo)));

localDir = "/home/nn";
        QUrl url("ftp://192.168.1.146");
        ftp->connectToHost(url.host(),url.port(21));
        ftp->login();
    connect(ftp, SIGNAL(commandFinished(int,bool)), this, SLOT(ftpCommandFinished(int,bool)));
    connect(ftp, SIGNAL(listInfo(QUrlInfo)), this, SLOT(ftpListInfo(QUrlInfo)));

To copy to clipboard, switch view to plain text mode 

void MainWindow::ftpCommandFinished(int, bool error)
{
    if(ftp->currentCommand() == QFtp::ConnectToHost)
    {
        ftp->login();
    }
 
    if(ftp->currentCommand() == QFtp::Login)
    {
        ftp->list();
    }
 
    if(ftp->currentCommand() == QFtp::Get)
    {
        file->close();
    }
 
    if(ftp->currentCommand() == QFtp::List)
    {
        download(listF);
    }
}

void MainWindow::ftpCommandFinished(int, bool error)
{
    if(ftp->currentCommand() == QFtp::ConnectToHost)
    {
        ftp->login();
    }

    if(ftp->currentCommand() == QFtp::Login)
    {
        ftp->list();
    }

    if(ftp->currentCommand() == QFtp::Get)
    {
        file->close();
    }

    if(ftp->currentCommand() == QFtp::List)
    {
        download(listF);
    }
}

To copy to clipboard, switch view to plain text mode 

void MainWindow::ftpListInfo(QUrlInfo urlInfo)
{
    if(urlInfo.isFile() && urlInfo.isReadable())
    {
        listF.append(urlInfo);
    }
}

void MainWindow::ftpListInfo(QUrlInfo urlInfo)
{
    if(urlInfo.isFile() && urlInfo.isReadable())
    {
        listF.append(urlInfo);
    }
}

To copy to clipboard, switch view to plain text mode 

void MainWindow::download(QList<QUrlInfo> listF)
{
foreach(QUrlInfo urlInfo, listF)
if(urlInfo.isFile() && urlInfo.isReadable())
    {
        file = new QFile(localDir + "/" + urlInfo.name());
        file->open(QIODevice::WriteOnly);
        ftp->get(urlInfo.name(), file);
    }
}

void MainWindow::download(QList<QUrlInfo> listF)
{
foreach(QUrlInfo urlInfo, listF)
if(urlInfo.isFile() && urlInfo.isReadable())
    {
        file = new QFile(localDir + "/" + urlInfo.name());
        file->open(QIODevice::WriteOnly);
        ftp->get(urlInfo.name(), file);
    }
}

To copy to clipboard, switch view to plain text mode 

[wysota]

You're not checking that each file actually gets downloaded. When you get commandFinished() after "get", you close "file" which is a global variable. Since QFtp::get() only schedules a download, your foreach loop completes before the first download is even started. As a result you end up with "file" assigned with the file belonging to the last "get" request but when the first "get" request completes, you close the last file (and not the first one, so the first one remains open and the last one is closed with 0 size). You need to pay attention to what QFtp::get() returns and associate it with the file handler so that you can retrieve the handle back when you receive commandFinished() signal. And fix those memory leaks.

[mahi6a1985]

You're not checking that each file actually gets downloaded. When you get commandFinished() after "get", you close "file" which is a global variable. Since QFtp::get() only schedules a download, your foreach loop completes before the first download is even started. As a result you end up with "file" assigned with the file belonging to the last "get" request but when the first "get" request completes, you close the last file (and not the first one). You need to pay attention to what QFtp::get() returns and associate it with the file handler so that you can retrieve the handle back when you receive commandFinished() signal. And fix those memory leaks.

Ok, i will try that. thanks

[wysota]

Your code is wrong. Period.