Get item text from model

[Higgs]

I'm writing phone book software(for educational purposes) I have 1 tableView,one QStandardItemModel,4 buttons(add,edit,delete,clear all)
here is a picture:
Capture.JPG

add button works correctly. But Edit button doesn't work correctly,as I want.
I add one person's number with Add button and then when I want to edit contact,I press edit Button but suddenly it crashes.
Capture.JPG

But,when I add new contact directly in tableView without add button, and then press Edit. That works. I can edit contact without any problems.
Capture.JPG
So,problem is when new contact is added via Add button. I can't see what is the problem.
source code of add and edit buttons

void MainWindow::on_pushButtonAdd_clicked()
{
    ChangeDialog dg;
    dg.setWindowTitle(tr("Add new contact"));
    QStringList list;
    if(dg.exec() == QDialog::Accepted){
        list << dg.GetList();
        for(int i = 0; i < 4;i++){
            QStandardItem *item = new QStandardItem(QString("%1").arg(list.at(i)));
            item->setEditable(false);
            model->setItem(rowCount,i,item);
        }
    }
    rowCount++;
}
 
void MainWindow::on_pushButtonEdit_clicked()
{
    ChangeDialog dg;
    dg.setWindowTitle(tr("Edit contact"));
    QStringList Slist;
 
 
    for(int i = 0; i < 4; i++){
            Slist.append(model->item(rowCount,i)->text());
            //QMessageBox::information(this,"title","asd");
    }
 
    dg.SetList(Slist);
    QStringList list2;
    if(dg.exec() == QDialog::Accepted){
        list2 << dg.GetList();
        for(int i = 0; i < 4;i++){
            QStandardItem *item2 = new QStandardItem(QString("%1").arg(list2.at(i)));
            item2->setEditable(false);
            model->setItem(rowCount,i,item2);
        }
    }
}

void MainWindow::on_pushButtonAdd_clicked()
{
    ChangeDialog dg;
    dg.setWindowTitle(tr("Add new contact"));
    QStringList list;
    if(dg.exec() == QDialog::Accepted){
        list << dg.GetList();
        for(int i = 0; i < 4;i++){
            QStandardItem *item = new QStandardItem(QString("%1").arg(list.at(i)));
            item->setEditable(false);
            model->setItem(rowCount,i,item);
        }
    }
    rowCount++;
}

void MainWindow::on_pushButtonEdit_clicked()
{
    ChangeDialog dg;
    dg.setWindowTitle(tr("Edit contact"));
    QStringList Slist;


    for(int i = 0; i < 4; i++){
            Slist.append(model->item(rowCount,i)->text());
            //QMessageBox::information(this,"title","asd");
    }

    dg.SetList(Slist);
    QStringList list2;
    if(dg.exec() == QDialog::Accepted){
        list2 << dg.GetList();
        for(int i = 0; i < 4;i++){
            QStandardItem *item2 = new QStandardItem(QString("%1").arg(list2.at(i)));
            item2->setEditable(false);
            model->setItem(rowCount,i,item2);
        }
    }
}

To copy to clipboard, switch view to plain text mode 

[anda_skoa]

Where do you get "rowCount" from?

Maybe it is outside the valid range of 0 <= rowCount < mode->rowCount()

If it is then model->item() will return 0 and accessing text() on a null pointer will crash.

Cheers,
_

[Higgs]

you are right I noticed that now. What a stupid mistake
rowCount variable comes from here:

class MainWindow : public QMainWindow
{
    Q_OBJECT
 
public:
    explicit MainWindow(QWidget *parent = 0);
    int rowCount;
    ~MainWindow();

class MainWindow : public QMainWindow
{
    Q_OBJECT

public:
    explicit MainWindow(QWidget *parent = 0);
    int rowCount;
    ~MainWindow();

To copy to clipboard, switch view to plain text mode 

when I add new contact, "rowCount" increased by one and then item() returns 0 and can't call text(). So it crashes. I understand.

----
In last one hour I wrote completely new code. And when I saw your reply, I now have two different code.
Code 2:

ChangeDialog dg;
    QStringList listOne;
    QModelIndexList indexes = ui->tableView->selectionModel()->selection().indexes();
    for(int i = 0; i < indexes.count(); ++i){
        QModelIndex index = indexes.at(i);
        QVariant v = index.data();
        listOne.append(v.toString());
    }
    dg.SetList(listOne);
    QStringList list;
    if(dg.exec() == QDialog::Accepted){
        list = dg.GetList();
        for(int i = 0; i < 4;i++){
            QStandardItem *item = new QStandardItem(QString("%1").arg(list.at(i)));
            item->setEditable(false);
            model->setItem(ui->tableView->currentIndex().row(),i,item);
        }
    }

ChangeDialog dg;
    QStringList listOne;
    QModelIndexList indexes = ui->tableView->selectionModel()->selection().indexes();
    for(int i = 0; i < indexes.count(); ++i){
        QModelIndex index = indexes.at(i);
        QVariant v = index.data();
        listOne.append(v.toString());
    }
    dg.SetList(listOne);
    QStringList list;
    if(dg.exec() == QDialog::Accepted){
        list = dg.GetList();
        for(int i = 0; i < 4;i++){
            QStandardItem *item = new QStandardItem(QString("%1").arg(list.at(i)));
            item->setEditable(false);
            model->setItem(ui->tableView->currentIndex().row(),i,item);
        }
    }

To copy to clipboard, switch view to plain text mode 

And old code
Code 1:

ChangeDialog dg;
   dg.setWindowTitle(tr("Edit contact"));
   QStringList Slist;
 
 
   for(int i = 0; i < 4; i++){
        Slist.append(model->item(ui->tableView->currentIndex().row(),i)->text());
        //QMessageBox::information(this,"title","asd");
   }
 
   dg.SetList(Slist);
   QStringList list2;
   if(dg.exec() == QDialog::Accepted){
   list2 << dg.GetList();
   for(int i = 0; i < 4;i++){
           QStandardItem *item2 = new QStandardItem(QString("%1").arg(list2.at(i)));
           item2->setEditable(false);
           model->setItem(ui->tableView->currentIndex().row(),i,item2);
   }
   }

ChangeDialog dg;
   dg.setWindowTitle(tr("Edit contact"));
   QStringList Slist;


   for(int i = 0; i < 4; i++){
        Slist.append(model->item(ui->tableView->currentIndex().row(),i)->text());
        //QMessageBox::information(this,"title","asd");
   }

   dg.SetList(Slist);
   QStringList list2;
   if(dg.exec() == QDialog::Accepted){
   list2 << dg.GetList();
   for(int i = 0; i < 4;i++){
           QStandardItem *item2 = new QStandardItem(QString("%1").arg(list2.at(i)));
           item2->setEditable(false);
           model->setItem(ui->tableView->currentIndex().row(),i,item2);
   }
   }

To copy to clipboard, switch view to plain text mode 

But I changed Code 1's rowCount to this: "ui->tableView->currentIndex().row()"
------

Both code do the same job but both have one problem. When I add new contact and then I edit contact. Edited contact is not fully edited.
Here is a picture:
1.JPG

2.JPG

3.JPG

BUT,when I change Code 1's: "ui->tableView->currentIndex().row()" to This: "rowCount",Here is a result
5.JPG

And the same happens if I change Code 2's ""ui->tableView->currentIndex().row()" to "rowCount".

I dont want to add new contact. I want fully edit contact,not just NAME field

---

Added after 19 minutes:

I solved Code 2's problem. I changed this line:

model->setItem(indexes.at(i).row(),i,item);

model->setItem(indexes.at(i).row(),i,item);

To copy to clipboard, switch view to plain text mode 

And this works

In Code 1. I'm still thinking to find solution