QPushButton if passed by reference to initialize, app crashing on connect statement

[rawfool]

I have written a function which takes argument as QPushButton pointer, to initialize and apply stylesheet. And later wrote connect statements for the corresponding buttons. On running the application, it is crashing at connect statement. On debugging it's showing segmentation fault. If I comment the connect statements the application runs fine.

If I can see the buttons laid out & also styles applied to them, then why is it giving the segmentation fault error which resembles for unallocated pointers ?

MyWidget::MyWidget(QWidget * parent)
    : QWidget(parent)
{
    vLyt = new QVBoxlayout;
    this->setLayout(vLyt);
    addButtons(btn1, "background: green");
    addButtons(btn2, "background: white");
    addButtons(btn3, "background: black");
    addButtons(btn4, "background: blue");
 
    connect(btn1, SIGNAL(clicked(bool)), this, SLOT(mySlot1(bool)));   // <<---   In debug mode, it's crashing here
    connect(btn2, SIGNAL(clicked(bool)), this, SLOT(mySlot2(bool)));
    connect(btn3, SIGNAL(clicked(bool)), this, SLOT(mySlot3(bool)));
    connect(btn4, SIGNAL(clicked(bool)), this, SLOT(mySlot4(bool)));
}
 
void MyWidget::addButtons(QPushButton * pb, QString str)
{
    pb = new QPushButton;
    pb->setCheckable(true);
    pb->setStyleSheet(str);
    vLyt->addWidget(pb);
}

MyWidget::MyWidget(QWidget * parent)
    : QWidget(parent)
{
    vLyt = new QVBoxlayout;
    this->setLayout(vLyt);
    addButtons(btn1, "background: green");
    addButtons(btn2, "background: white");
    addButtons(btn3, "background: black");
    addButtons(btn4, "background: blue");

    connect(btn1, SIGNAL(clicked(bool)), this, SLOT(mySlot1(bool)));   // <<---   In debug mode, it's crashing here
    connect(btn2, SIGNAL(clicked(bool)), this, SLOT(mySlot2(bool)));
    connect(btn3, SIGNAL(clicked(bool)), this, SLOT(mySlot3(bool)));
    connect(btn4, SIGNAL(clicked(bool)), this, SLOT(mySlot4(bool)));
}

void MyWidget::addButtons(QPushButton * pb, QString str)
{
    pb = new QPushButton;
    pb->setCheckable(true);
    pb->setStyleSheet(str);
    vLyt->addWidget(pb);
}

To copy to clipboard, switch view to plain text mode 

Why does the application crash at connect statement ?

[anda_skoa]

Why does the application crash at connect statement ?

Hint: check the value of btn1 before and after

addButtons(btn1, "background: green");

addButtons(btn1, "background: green");

To copy to clipboard, switch view to plain text mode 

Cheers,
_

[rawfool]

Oh got it.
Now I changed it like this & it's working fine.

MyWidget::MyWidget(QWidget * parent)
    : QWidget(parent)
{
    ...
    ...
    btn1 = addButtons( "background: green");
}
 
QToolButton * MyWidget::addButtons(QString str)
{
    QPushButton * pb = new QPushButton;
    pb->setCheckable(true);
    pb->setStyleSheet(str);
    vLyt->addWidget(pb);  // <<---        Adding the button to the layout here. Is it ok ??
 
    return pb;
}

MyWidget::MyWidget(QWidget * parent)
    : QWidget(parent)
{
    ...
    ...
    btn1 = addButtons( "background: green");
}

QToolButton * MyWidget::addButtons(QString str)
{
    QPushButton * pb = new QPushButton;
    pb->setCheckable(true);
    pb->setStyleSheet(str);
    vLyt->addWidget(pb);  // <<---        Adding the button to the layout here. Is it ok ??

    return pb;
}

To copy to clipboard, switch view to plain text mode 

[anda_skoa]

That doesn't look like something that would compile.

"pb" is of type QPushButton* but the method return value is of type QToolButton*, so either of the two needs to be changed.

Adding the button to the layout in there should be OK

Cheers,
_

[rawfool]

Oh sorry for the typo. I meant QToolButton there.
Thank you.

[Infinity]

To your code from the first post: You don't pass a QPushButton by reference. You pass "a pointer to QPushButton by value". That's why btn1/2/3/4 doesn't change after calling addButtons - just a copy of that pointer changes.
The following piece of code might work.

void MyWidget::addButtons(QPushButton *&pb, const QString &str)
{
pb = new QPushButton(this);
pb->setCheckable(true);
pb->setStyleSheet(str);
vLyt->addWidget(pb);
}

void MyWidget::addButtons(QPushButton *&pb, const QString &str)
{
pb = new QPushButton(this);
pb->setCheckable(true);
pb->setStyleSheet(str);
vLyt->addWidget(pb);
}

To copy to clipboard, switch view to plain text mode