QThread: Destroyed while thread is still running

[Shuchi Agrawal]

when i do
void MainWindowImpl::Stop_Thread()
{
flag_stop = true;
producer->wait();
consumer->wait();
}
then, if i dont press "Stop Thread" botton then i get
"Running...
QWaitCondition: Destroyed while threads are still waiting"
and is i press stop thread button t hen the program doesnt respond.

Globalvar.h
#ifndef __GLOBALVAR_H__
#define __GLOBALVAR_H__
#include <QSemaphore>
#include <QString>
extern QSemaphore freeBytes;
extern QSemaphore usedBytes;
extern QString read_str, write_str;
extern bool flag_read,flag_write,flag_stop;
extern char buffer[8096];
#endif // __GLOBALVAR_H__

Globalvar.cpp
#include "globalvar.h"
char buffer[8096];
QSemaphore freeBytes(8096);
QSemaphore usedBytes;
QString read_str, write_str;
bool flag_read = false ,flag_write = false, flag_stop = false;

So can u plz help me out?
Thanks.

[wysota]

Your application hangs because the threads are sleeping on their semaphores. You should first make sure the "flag_stop" will really stop them without making one of the threads sleep on its semaphore because of an empty/full buffer - if the "flag_stop" is set when the thread is already sleeping, it might never be woken up.

The bottom line is, you have to go through your synchronisation mechanism again and rethink/correct it.

For example this could work:

void MainWindowImpl::Stop_Thread()
{
  flag_stop = true;
  producer->release();
  consumer->release();
  producer->wait();
  consumer->wait();
}
 
void Producer::run()
{
      i=0;
      while(!flag_stop)
      {
          if(flag_read)
          {
             freeBytes.acquire();
             if(flag_stop) return;
             int n = read_str.size();
              buffer[i % 8096] = (*((read_str.toUtf8().constData())+(n-1)));
              i++;
              usedBytes.release();
              flag_read = false;
         }
 
       }
      flag_stop = true;
}
 
void Consumer::run()
{
   j=0;
   while(!flag_stop)
   {
           usedBytes.acquire();
           if(flag_stop) return;
           write_str += buffer[j % 8096];
           j++;
           freeBytes.release();
           emit disp();  // disp a slot of mainwindow.cpp
   }
   flag_stop = true;
}

void MainWindowImpl::Stop_Thread()
{
  flag_stop = true;
  producer->release();
  consumer->release();
  producer->wait();
  consumer->wait();
}

void Producer::run()
{
      i=0;
      while(!flag_stop)
      {
          if(flag_read)
          {
             freeBytes.acquire();
             if(flag_stop) return;
             int n = read_str.size();
              buffer[i % 8096] = (*((read_str.toUtf8().constData())+(n-1)));
              i++;
              usedBytes.release();
              flag_read = false;
         }
 
       }
      flag_stop = true;
}

void Consumer::run()
{
   j=0;
   while(!flag_stop)
   {
           usedBytes.acquire();
           if(flag_stop) return;
           write_str += buffer[j % 8096];
           j++;
           freeBytes.release();
           emit disp();  // disp a slot of mainwindow.cpp
   }
   flag_stop = true;
}

To copy to clipboard, switch view to plain text mode 

As for the other problem - make sure you call Stop_Thread() before closing the application.

[Shuchi Agrawal]

Hi all,
i am still having the same problem. i am not that good in programming and thus i am unable to fix this small problem. Please i wil be greatful to all who can help me out.
I am not able to stop the threads. How to do it. The code is given in the .zip file.
Threading.zip
Thanks all.

[wysota]

I guess you didn't try my solution...

[Shuchi Agrawal]

I guess you didn't try my solution...

yes i do tried solution given by you, but the entire program hangs on clicking "stop thread" button.

void MainWindowImpl::Stop_Thread()
{	flag_stop = true;
	freeBytes.release();  //QSemaphore freeBytes;
	usedBytes.release();  //QSemaphore usedBytes;
	producer->wait();  
	consumer->wait();
}

void MainWindowImpl::Stop_Thread()
{	flag_stop = true;
	freeBytes.release();  //QSemaphore freeBytes;
	usedBytes.release();  //QSemaphore usedBytes;
	producer->wait();  
	consumer->wait();
}

To copy to clipboard, switch view to plain text mode 

So can u tel me where i m doing wrong.i wil be greatful beause i am reallly stuck here.

[wysota]

This is not what I suggested. I suggested checking the stop flag after going through the acquire call. The thing you do in your code snippet you pasted here does nothing. Many things can happen between release() and wait().

[Shuchi Agrawal]

Thanks a lot Wysota. i solved the problem by taking the approach "Your application hangs because the threads are sleeping on their semaphores. You should first make sure the "flag_stop" will really stop them without making one of the threads sleep on its semaphore because of an empty/full buffer - if the "flag_stop" is set when the thread is already sleeping, it might never be woken up." - quoted by you. Thanks a lot