QProcess ping

[soulmaster17]

Hello there. I'm trying to make a ping application. The application start but nothing is shown.
Here is my code.

#include "ping.h"
#include "ui_ping.h"
 
//#include <iostream>
//#include <stdio.h>
//#include <stdlib.h>
 
#include <QtGui>
#include <QApplication>
#include <QMessageBox>
#include <QTextEdit>
#include <QtNetwork/QTcpSocket>
#include <QPlainTextEdit>
#include <QtNetwork>
 
//using namespace std;
 
ping::ping(QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::ping)
{
    ui->setupUi(this);
 
}
 
ping::~ping()
{
    delete ui;
}
 
 
void ping::on_pushButton_clicked()
{
    QString m_sHostName = ui->lineEdit->text();
 
 
 
    // Create QProcess object
    QProcess *proc;
    proc = new QProcess();
    proc->start("ping", QStringList() << QString(m_sHostName), QIODevice::ReadOnly);
    proc->waitForFinished(-1);
 
 
 
 
 // Show output
   ui->plainTextEdit->connect(proc, SIGNAL(readyReadStandardOutput()), this, SLOT(show()));
    ui->plainTextEdit->connect(proc, SIGNAL(readyReadStandardError()), this, SLOT(show()));
 
 
 
}
 
 
// Show right message
void ping::rightMessage()
{
    QProcess *proc;
    proc = new QProcess();
 
 
    QByteArray strdata = proc->readAllStandardOutput();
    strdata = strdata.simplified();
    strdata = strdata.trimmed();
 
    //ui->TextEditResult->setTextColor(Qt::black);
    ui->plainTextEdit->appendPlainText(strdata);
  //  ui->plainTextEdit->appendPlainText("<br>");
 
}
 
 
// Show wrong message
void ping::wrongMessage()
{
    QProcess *proc;
    proc = new QProcess();
 
    QByteArray strdata = proc->readAllStandardError();
    //ui->TextEditResult->setTextColor(Qt::red);
    ui->plainTextEdit->appendPlainText(strdata);
}

#include "ping.h"
#include "ui_ping.h"

//#include <iostream>
//#include <stdio.h>
//#include <stdlib.h>

#include <QtGui>
#include <QApplication>
#include <QMessageBox>
#include <QTextEdit>
#include <QtNetwork/QTcpSocket>
#include <QPlainTextEdit>
#include <QtNetwork>

//using namespace std;

ping::ping(QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::ping)
{
    ui->setupUi(this);

}

ping::~ping()
{
    delete ui;
}


void ping::on_pushButton_clicked()
{
    QString m_sHostName = ui->lineEdit->text();



    // Create QProcess object
    QProcess *proc;
    proc = new QProcess();
    proc->start("ping", QStringList() << QString(m_sHostName), QIODevice::ReadOnly);
    proc->waitForFinished(-1);




 // Show output
   ui->plainTextEdit->connect(proc, SIGNAL(readyReadStandardOutput()), this, SLOT(show()));
    ui->plainTextEdit->connect(proc, SIGNAL(readyReadStandardError()), this, SLOT(show()));



}


// Show right message
void ping::rightMessage()
{
    QProcess *proc;
    proc = new QProcess();


    QByteArray strdata = proc->readAllStandardOutput();
    strdata = strdata.simplified();
    strdata = strdata.trimmed();

    //ui->TextEditResult->setTextColor(Qt::black);
    ui->plainTextEdit->appendPlainText(strdata);
  //  ui->plainTextEdit->appendPlainText("<br>");

}


// Show wrong message
void ping::wrongMessage()
{
    QProcess *proc;
    proc = new QProcess();

    QByteArray strdata = proc->readAllStandardError();
    //ui->TextEditResult->setTextColor(Qt::red);
    ui->plainTextEdit->appendPlainText(strdata);
}

To copy to clipboard, switch view to plain text mode 

[anda_skoa]

You connect to the QProgress signals after it has finished.

You also connected to the window's show() slot and never read any data from the process.

Cheers,
_

[d_stranz]

I think you want to connect to the "rightMessage()" and "wrongMessage()" slots, not "show()". Maybe you got a little confused, thinking that you wanted to "show" the results of the ping operations...

[soulmaster17]

Thank you for the answers.


I uncomment the line proc->waitForFinished(-1);
Then i write in my main.cpp file, w.rightMessage(); instead of w.show();
But now i get QIODevice::read (QProcess): device not open.
Any idea?

---

Added after 20 minutes:

I also replace the word show by rightMessage() and wrongMessage() respectively, just like this

ui->plainTextEdit->connect(proc, SIGNAL(readyReadStandardOutput()), this, SLOT(rightMessage()));

ui->plainTextEdit->connect(proc, SIGNAL(readyReadStandardOutput()), this, SLOT(rightMessage()));

To copy to clipboard, switch view to plain text mode 

but i get
Starting /root/build-ping-QtKit-Debug/ping...
QIODevice::read (QProcess): device not open
/root/build-ping-QtKit-Debug/ping exited with code 0

[d_stranz]

You connect to the QProgress signals after it has finished.

Did you read anda_skoa's comment?

[soulmaster17]

Yes i did. But escuse me Mister, i'm a total newbie, and i really want to know how to execute linux or windows commands in a window like this. I will apreciate any suggestions from you. Take care

[anda_skoa]

In both slots, rightMessage() and wrongMessage(), you are creating a new QProcess and try to read from that instead from the process that was actually executed.

You need a QProcess as a member of your class and refer to that instance from all your methods.

Cheers,
_