How to erase all the files and folders in the Selected existing directory

**marcel** · 30th July 2007, 08:53

Originally Posted by marcel

Then just delete it outside the function after the directory's contents are all removed.

Regards

Have you tried this?
Can you post a bigger part of the code?
But first try deleting the dir after you call the recursive function.

Regards

**merry** · 30th July 2007, 09:05

Hi Marcel

Really I tried it lots & lots of times but it does not remove directories,It removes all the files but not directories .

Ok Pls view my code , and tell me is I m doin something wrong.

Qt Code:

Switch view

void Form1::DeleteData(QString dirViewPath)
    {     
      QDir dirPath(dirViewPath); 
         if (dirPath.exists())
		 {
		   QList<QFileInfo> infLst = dirPath.entryInfoList();
		   for(int i=0;i<infLst.size();i++)
           {
	         QFileInfo strFileInfo = infLst.at(i);
	         QString strFileName = strFileInfo.fileName();
	         if(!(strFileInfo.fileName() == "." || strFileInfo.fileName() == ".."))
		      {
	           if(strFileInfo.isDir())
	            {
		           QString strFilePath = dirViewPath + "/" + strFileInfo.fileName();
                    QString fileName = strFileInfo.fileName();
			        DeleteData(strFilePath);
				}
			  else
	            {
				  unsigned char *pBuff;
				  FILE *fh  = NULL;
				  QString fileName = dirViewPath + "/" + strFileInfo.fileName();
				  QFile file1(fileName);
				  long SizeToRead =fileName.size();
				  fh=fopen((const char*)fileName.toAscii() ,"wb+");
				  pBuff = new unsigned char[SizeToRead];
				  QString str;
				  str = comboBox->itemText(comboBox->currentIndex());
				  bool ok;
				  int val= str.toInt(&ok,36);  
				  memset(pBuff,val,SizeToRead);
				  fwrite((void*)pBuff,SizeToRead,1,fh);
				  delete []pBuff;
				  pBuff=NULL;
				  fclose(fh);
				  file1.remove();
			 }
		  }
	  }
              dirPath.cdUp();
		 dirPath.rmdir(dirViewPath);
			     }
  }

void Form1::DeleteData(QString dirViewPath)
    {     
      QDir dirPath(dirViewPath); 
         if (dirPath.exists())
		 {
		   QList<QFileInfo> infLst = dirPath.entryInfoList();
		   for(int i=0;i<infLst.size();i++)
           {
	         QFileInfo strFileInfo = infLst.at(i);
	         QString strFileName = strFileInfo.fileName();
	         if(!(strFileInfo.fileName() == "." || strFileInfo.fileName() == ".."))
		      {
	           if(strFileInfo.isDir())
	            {
		           QString strFilePath = dirViewPath + "/" + strFileInfo.fileName();
                    QString fileName = strFileInfo.fileName();
			        DeleteData(strFilePath);
				}
			  else
	            {
				  unsigned char *pBuff;
				  FILE *fh  = NULL;
				  QString fileName = dirViewPath + "/" + strFileInfo.fileName();
				  QFile file1(fileName);
				  long SizeToRead =fileName.size();
				  fh=fopen((const char*)fileName.toAscii() ,"wb+");
				  pBuff = new unsigned char[SizeToRead];
				  QString str;
				  str = comboBox->itemText(comboBox->currentIndex());
				  bool ok;
				  int val= str.toInt(&ok,36);  
				  memset(pBuff,val,SizeToRead);
				  fwrite((void*)pBuff,SizeToRead,1,fh);
				  delete []pBuff;
				  pBuff=NULL;
				  fclose(fh);
				  file1.remove();
			 }
		  }
	  }
              dirPath.cdUp();
		 dirPath.rmdir(dirViewPath);
			     }
  }

To copy to clipboard, switch view to plain text mode

Thanx

**marcel** · 30th July 2007, 09:09

But I really wanted to know where you call DeleteData.
Could you post that part of the code?

Regards

**merry** · 30th July 2007, 09:54

Hi..

I m sending u both .h and .cpp files Pls view this code.

Form1.h

Qt Code:

Switch view

class Form1:public QDialog,private Ui::Form1
{
	Q_OBJECT
	public:
	Form1::Form1(QWidget *parent): QDialog(parent)
	{
		setupUi(this);
		connect(File,SIGNAL(clicked()),this,SLOT(ShowFileDialog()));
		connect(Erase,SIGNAL(clicked()),this,SLOT(CallDeleteData()));
	};	
		private slots:
		void ShowFileDialog();
		void DeleteData(QString);
		void CallDeleteData();
		protected:
		QString m_file;
};

class Form1:public QDialog,private Ui::Form1
{
	Q_OBJECT
	public:
	Form1::Form1(QWidget *parent): QDialog(parent)
	{
		setupUi(this);
		connect(File,SIGNAL(clicked()),this,SLOT(ShowFileDialog()));
		connect(Erase,SIGNAL(clicked()),this,SLOT(CallDeleteData()));
	};	
		private slots:
		void ShowFileDialog();
		void DeleteData(QString);
		void CallDeleteData();
		protected:
		QString m_file;
};

To copy to clipboard, switch view to plain text mode

Form1.cpp

Qt Code:

Switch view

void Form1::ShowFileDialog()
{
   m_file=QFileDialog::getExistingDirectory(this, tr("Open Directory"),
                                                 "/home",
                                                 QFileDialog::ShowDirsOnly
												| QFileDialog::DontResolveSymlinks);
 
  filename->setText(m_file);
 
}
 
void Form1::CallDeleteData()
{
DeleteData(m_file);
}
////////////////////////////////////////////////////////////////////////
 
/*Function for erasing*/
 
void Form1::DeleteData(QString dirViewPath)
    {     
      QDir dirPath(dirViewPath); 
         if (dirPath.exists())
		 {
		   QList<QFileInfo> infLst = dirPath.entryInfoList();
		   for(int i=0;i<infLst.size();i++)
           {
	         QFileInfo strFileInfo = infLst.at(i);
	         QString strFileName = strFileInfo.fileName();
	         if(!(strFileInfo.fileName() == "." || strFileInfo.fileName() == ".."))
		      {
	           if(strFileInfo.isDir())
	            {
		           QString strFilePath = dirViewPath + "/" + strFileInfo.fileName();
                    QString fileName = strFileInfo.fileName();
			        DeleteData(strFilePath);  //recursive Calling
				}
			  else
	            {
				  unsigned char *pBuff;
				  FILE *fh  = NULL;
				  QString fileName = dirViewPath + "/" + strFileInfo.fileName();
				  QFile file1(fileName);
				  long SizeToRead =fileName.size();
				  fh=fopen((const char*)fileName.toAscii() ,"wb+");
				  pBuff = new unsigned char[SizeToRead];
				  QString str;
				  str = comboBox->itemText(comboBox->currentIndex());
				  bool ok;
				  int val= str.toInt(&ok,36);  
				  memset(pBuff,val,SizeToRead);
				  fwrite((void*)pBuff,SizeToRead,1,fh);
				  delete []pBuff;
				  pBuff=NULL;
				  fclose(fh);
				  file1.remove();
			 }
		  }
	  }
              dirPath.cdUp();
		      dirPath.rmdir(dirViewPath);
	     }
  }

void Form1::ShowFileDialog()
{
   m_file=QFileDialog::getExistingDirectory(this, tr("Open Directory"),
                                                 "/home",
                                                 QFileDialog::ShowDirsOnly
												| QFileDialog::DontResolveSymlinks);
											
  filename->setText(m_file);

}

void Form1::CallDeleteData()
{
DeleteData(m_file);
}
////////////////////////////////////////////////////////////////////////

/*Function for erasing*/

void Form1::DeleteData(QString dirViewPath)
    {     
      QDir dirPath(dirViewPath); 
         if (dirPath.exists())
		 {
		   QList<QFileInfo> infLst = dirPath.entryInfoList();
		   for(int i=0;i<infLst.size();i++)
           {
	         QFileInfo strFileInfo = infLst.at(i);
	         QString strFileName = strFileInfo.fileName();
	         if(!(strFileInfo.fileName() == "." || strFileInfo.fileName() == ".."))
		      {
	           if(strFileInfo.isDir())
	            {
		           QString strFilePath = dirViewPath + "/" + strFileInfo.fileName();
                    QString fileName = strFileInfo.fileName();
			        DeleteData(strFilePath);  //recursive Calling
				}
			  else
	            {
				  unsigned char *pBuff;
				  FILE *fh  = NULL;
				  QString fileName = dirViewPath + "/" + strFileInfo.fileName();
				  QFile file1(fileName);
				  long SizeToRead =fileName.size();
				  fh=fopen((const char*)fileName.toAscii() ,"wb+");
				  pBuff = new unsigned char[SizeToRead];
				  QString str;
				  str = comboBox->itemText(comboBox->currentIndex());
				  bool ok;
				  int val= str.toInt(&ok,36);  
				  memset(pBuff,val,SizeToRead);
				  fwrite((void*)pBuff,SizeToRead,1,fh);
				  delete []pBuff;
				  pBuff=NULL;
				  fclose(fh);
				  file1.remove();
			 }
		  }
	  }
              dirPath.cdUp();
		      dirPath.rmdir(dirViewPath);
	     }
  }

To copy to clipboard, switch view to plain text mode

**marcel** · 30th July 2007, 10:02

In CallDeleteData():

Qt Code:

Switch view

void Form1::CallDeleteData()
{
   DeleteData(m_file);
  QDir dir(m_file);
   if( dir.cdUp() ) 
  {
   dir.rmdir(m_file);
   }
}

void Form1::CallDeleteData()
{
   DeleteData(m_file);
  QDir dir(m_file);
   if( dir.cdUp() ) 
  {
   dir.rmdir(m_file);
   }
}

To copy to clipboard, switch view to plain text mode

Also, remove lines 60 and 61 from DeleteData. They are not needed anymore.

Regards

**merry** · 30th July 2007, 10:15

Thanx Marcel for the reply.

I tried it , but directories are still there..

DeleteData function is recursively Calling.....

Thanx...

**marcel** · 30th July 2007, 10:22

Originally Posted by merry

Thanx

It works , It deletes all the files contained in the folder,

but is there any other way , that after deleting all the files of the folder it also deletes that folder .

Thanx

But you said that the contained files and folders are deleted.
I understood that your only problem is the parent folder. You couldn't delete that.

Which one is it?

Regards

**merry** · 30th July 2007, 10:27

Actually I said that it deletes all the Files that are in the folders , and empty folders are left.....,

eg..

If there is a folder name "dir1" it further contains files(F1 , F2) and folder dir2.

then F1 and F2 are deleted but empty dir1 and dir2 folders are left....

My question is how can i delete empty folders?

Thanx

**marcel** · 30th July 2007, 10:33

But you messed up the code.
In the case you run into a directory:

Qt Code:

Switch view

QDir subDir(finfo.absolutePath());
dir.rmdir(subDir);

QDir subDir(finfo.absolutePath());
dir.rmdir(subDir);

To copy to clipboard, switch view to plain text mode

You removed that.
It should work, as long as the directory is not used/empty.
Couldn't you debug it to see exactly what is wrong?

**merry** · 30th July 2007, 10:43

Qt Code:

Switch view

QDir subDir(finfo.absolutePath());
dir.rmdir(subDir);

QDir subDir(finfo.absolutePath());
dir.rmdir(subDir);

To copy to clipboard, switch view to plain text mode

Are u sure it works..
The function is like this only...

QDir::rmdir ( const QString & dirName )

and subDir is of QDir type...

and parameters passed in the function are of QString type...

Thanx

**marcel** · 30th July 2007, 10:46

Originally Posted by merry

Qt Code:

Switch view

QDir subDir(finfo.absolutePath());
dir.rmdir(subDir);

QDir subDir(finfo.absolutePath());
dir.rmdir(subDir);

To copy to clipboard, switch view to plain text mode

Are u sure it works..
The function is like this only...

QDir::rmdir ( const QString & dirName )

and subDir is of QDir type...

and parameters passed in the function are of QString type...

Thanx

Well, fix it!
Pass finfo.absolutePath() to rmdir.
subdir has to be empty at that moment. so,a rmdir from the parent should work.

What about the debugging?

**marcel** · 30th July 2007, 11:04

Here it is. I just tested it:

This is where it starts( the wrapper):

Qt Code:

Switch view

void qttest::clearAll() 
{
    QString dirRoot = "c:\\testdir";
    clearAll(dirRoot);
    QDir d(dirRoot);
    d.cdUp();
    d.rmdir(dirRoot);
}

void qttest::clearAll() 
{
    QString dirRoot = "c:\\testdir";
    clearAll(dirRoot);
    QDir d(dirRoot);
    d.cdUp();
    d.rmdir(dirRoot);
}

To copy to clipboard, switch view to plain text mode

This is the actual function:

Qt Code:

Switch view

void qttest::clearAll(QString dirPath) 
{
  QDir dir(dirPath);
  QList<QFileInfo> infLst = dir.entryInfoList(QDir::AllEntries | QDir::NoDotAndDotDot);
  foreach(QFileInfo finfo, infLst )
  {
    if(finfo.isDir() )
    {
      clearAll(finfo.absoluteFilePath());
      dir.rmdir(finfo.absoluteFilePath());
    }
    else 
    { //file
        dir.remove(finfo.absoluteFilePath());
    }
  }
}

void qttest::clearAll(QString dirPath) 
{
  QDir dir(dirPath);
  QList<QFileInfo> infLst = dir.entryInfoList(QDir::AllEntries | QDir::NoDotAndDotDot);
  foreach(QFileInfo finfo, infLst )
  {
    if(finfo.isDir() )
    {
      clearAll(finfo.absoluteFilePath());
      dir.rmdir(finfo.absoluteFilePath());
    }
    else 
    { //file
        dir.remove(finfo.absoluteFilePath());
    }
  }
}

To copy to clipboard, switch view to plain text mode

Regards.

**merry** · 30th July 2007, 11:43

Hi Marcel

Can u pls tell me in function

Qt Code:

Switch view

void qttest::clearAll() 
{
    QString dirRoot = "c:\\testdir";
    clearAll(dirRoot);
    QDir d(dirRoot);
    d.cdUp();
    d.rmdir(dirRoot);
}

void qttest::clearAll() 
{
    QString dirRoot = "c:\\testdir";
    clearAll(dirRoot);
    QDir d(dirRoot);
    d.cdUp();
    d.rmdir(dirRoot);
}

To copy to clipboard, switch view to plain text mode

Why you used this(4th line of the above code) that is:

Qt Code:

Switch view

clearAll(dirRoot);

clearAll(dirRoot);

To copy to clipboard, switch view to plain text mode

Thanx

**marcel** · 30th July 2007, 11:47

You should pass there the directory returned by the file dialog.
clearAll() without any parameters is just an overloaded variant of the second, provided for convenince.

It is really not that different than the first version.
I just passed a folder that I created on my hard disk.

And don't say it doesn't work because it does. If you don't mess up the code, then it will work for you too.

Regards

**merry** · 30th July 2007, 12:43

Hi Marcel

Thanx Marcel for helping me so much

Pls dont get angry on me....

I think I am not messing the code now , It is same as the code u sent to me , Is'nt it...

But it also deletes the files but not folders.....

Qt Code:

Switch view

void Form1::ShowFileDialog()
{
  m_file=QFileDialog::getExistingDirectory(this, tr("Open Directory"),
                                                 "/home",
                                                 QFileDialog::ShowDirsOnly
										  	| QFileDialog::DontResolveSymlinks);
 
 
 
filename->setText(m_file);
 
}
 
void Form1::DeleteData()
{  
    QString dirRoot = m_file;
    DeleteData(dirRoot);
    QDir d(dirRoot);
    d.cdUp();
    d.rmdir(dirRoot);
}
////////////////////////////////////////////////////////////////////////
 
/*Function for erasing*/
 
void Form1::DeleteData(QString dirViewPath)
    {     
      QDir dirPath(dirViewPath); 
         if (dirPath.exists())
		 {
		   QList<QFileInfo> infLst = dirPath.entryInfoList();
		   for(int i=0;i<infLst.size();i++)
           {
	         QFileInfo strFileInfo = infLst.at(i);
	         QString strFileName = strFileInfo.fileName();
	         if(!(strFileInfo.fileName() == "." || strFileInfo.fileName() == ".."))
		      {
	           if(strFileInfo.isDir())
	            {
		          		DeleteData(strFileInfo.absoluteFilePath());
					dirPath.rmdir(strFileInfo.absoluteFilePath());
                }
				else
	            {
 
				  dirPath.remove(strFileInfo.absoluteFilePath());
 
			  }
		   }
 
	   }
	}
  }

void Form1::ShowFileDialog()
{
  m_file=QFileDialog::getExistingDirectory(this, tr("Open Directory"),
                                                 "/home",
                                                 QFileDialog::ShowDirsOnly
										  	| QFileDialog::DontResolveSymlinks);
											
											
																							
filename->setText(m_file);

}

void Form1::DeleteData()
{  
    QString dirRoot = m_file;
    DeleteData(dirRoot);
    QDir d(dirRoot);
    d.cdUp();
    d.rmdir(dirRoot);
}
////////////////////////////////////////////////////////////////////////

/*Function for erasing*/

void Form1::DeleteData(QString dirViewPath)
    {     
      QDir dirPath(dirViewPath); 
         if (dirPath.exists())
		 {
		   QList<QFileInfo> infLst = dirPath.entryInfoList();
		   for(int i=0;i<infLst.size();i++)
           {
	         QFileInfo strFileInfo = infLst.at(i);
	         QString strFileName = strFileInfo.fileName();
	         if(!(strFileInfo.fileName() == "." || strFileInfo.fileName() == ".."))
		      {
	           if(strFileInfo.isDir())
	            {
		          		DeleteData(strFileInfo.absoluteFilePath());
					dirPath.rmdir(strFileInfo.absoluteFilePath());
                }
				else
	            {
				 
				  dirPath.remove(strFileInfo.absoluteFilePath());
				 
			  }
		   }
		   
	   }
	}
  }

To copy to clipboard, switch view to plain text mode

Thanx

**marcel** · 30th July 2007, 12:53

Are you sure you have permissions to delete the directories?
Are you running as root or as a normal user?

**merry** · 30th July 2007, 12:56

I m running as a normal user

**marcel** · 30th July 2007, 13:02

Well, could you try running it as root?

**merry** · 30th July 2007, 13:24

I tried it running as a root

It works , but for that directories only which contains files only.

not for that directories which contains both files and folders ..

Thanx

**marcel** · 30th July 2007, 13:33

Sorry, but can't help you. I really can't understand what's going on.
I tested it on the following structure. Every directory in there had 1,2 or three files in it.
So I can't say what is going on in your case.

Regards