static function/object accessibility

[vonCZ]

non-Qt parts: a Coin3d scenegraph. My current task: as the user rotates the model (thus moving the camera), I want to send the new camera X position to a QLabel's setNum() method. I haven't any trouble sending Qt instructions/parameters to the Coin3d class, but going the other way around--from Coin3d to Qt--is where I'm currently stuck.

[marcel]

Just make the label visible outside the window class.
Add a method getLabel in the window that returns the label. You can use it to call setText or connect signals to it.

You don't need the label to be static. It will work with a singleton.
Something like:

Window::getInstance()->getLabel()->setText("x");

Window::getInstance()->getLabel()->setText("x");

To copy to clipboard, switch view to plain text mode 

Regards

[vonCZ]

program compiles, but crashes when run. I've got:

// window.h
class Window : public QWidget {
 
  Q_OBJECT
 
public:
  Window();
  static Window* getInstance();
  QLabel *getLabel();
  QLabel *myLabel;
 
// window.cpp
  myLabel = new QLabel;
  Window* Window::getInstance() {
    static Window *win=0;
    if(!win) {
      win = new Window();
    }
    return win;
}
 
QLabel  *Window::getLabel() {
  return myLabel;
}
 
// model.h    ...Coin3d scenegraph
#include <Inventor/*/*.h>   //many
#include <QLabel>  //was surprised I had to include this
#include "window.h"
 
// model.cpp
 
  Window::getInstance()->getLabel()->setText("x");
  // Window::getInstance();   //also crashes

// window.h
class Window : public QWidget {

  Q_OBJECT

public:
  Window();
  static Window* getInstance();
  QLabel *getLabel();
  QLabel *myLabel;

// window.cpp
  myLabel = new QLabel;
  Window* Window::getInstance() {
    static Window *win=0;
    if(!win) {
      win = new Window();
    }
    return win;
}

QLabel  *Window::getLabel() {
  return myLabel;
}

// model.h    ...Coin3d scenegraph
#include <Inventor/*/*.h>   //many
#include <QLabel>  //was surprised I had to include this
#include "window.h"

// model.cpp

  Window::getInstance()->getLabel()->setText("x");
  // Window::getInstance();   //also crashes

To copy to clipboard, switch view to plain text mode 

based on the last commented line: looks like I'm not employing the Singleton correctly.

Another question though: the call to update the QLabel value will happen ~25 times a second as the camera is moved. Is this still a good way to connect the camera X-value to the QLabel?

[marcel]

What do you do in the constructor of Window?
It should work, although, you should add a static private Window membner, and take it out of get instance.

[vonCZ]

It should work, although, you should add a static private Window membner, and take it out of get instance.

ok, did that.

What do you do in the constructor of Window?

almost everything. Instantiate many of my widget objects, call functions to intantiate others, do connects, etc...


edit: NOTE my constructor is public.

i should also add: the application hangs for about 3-4 seconds, then crashes.

[marcel]

edit: NOTE my constructor is public.

Does not really matter, but it is not singleton if the constructor is not private.
If it is public it means that you can create other instances outside the class.

I am almost sure that something happens in the constructor.

Regards

[vonCZ]

Does not really matter, but it is not singleton if the constructor is not private.
If it is public it means that you can create other instances outside the class.

I am almost sure that something happens in the constructor.

Regards

well here's the code, when you or someone else has a moment.

"public it means that you can create other instances outside the class"- perhaps that's my problem. I'm calling:

Window::getInstance()->getLabel()->setText("x");

Window::getInstance()->getLabel()->setText("x");

To copy to clipboard, switch view to plain text mode 

from another class, Model. Isn't this call, then, creating a 2nd instance of Window? ...thus the hang/crash? I'll try making the constructor private, also I suspect doing so will cause all sorts of other problems...

[marcel]

from another class, Model. Isn't this call, then, creating a 2nd instance of Window? ...thus the hang/crash? I'll try making the constructor private, also I suspect doing so will cause all sorts of other problems...

It won't create another instance because getInstance tests if there already is an instance available. That is the whole point of singletons.

Keeping the constructor public allows something like this from another class:

Window *w = new Window();

Window *w = new Window();

To copy to clipboard, switch view to plain text mode 

therefore creating another instance, other than the static one.

So you should make the constructor private to prevent it from being accessed from any other class than Window.

well here's the code, when you or someone else has a moment.

I can't compile it, bu I'll take a look.

Regards

[marcel]

Who initializes the members of Window::dafo?

for(int a=0; a<dafo.get_compNUM_TOT(); a++)
    {
      mkLyBuLayout(a);   //   comp Number
    }

for(int a=0; a<dafo.get_compNUM_TOT(); a++)
    {
      mkLyBuLayout(a);   //   comp Number
    }

To copy to clipboard, switch view to plain text mode 

This code could cause the seg fault if get_compNUM_TOT returns an uninitialized int.

Regards

[vonCZ]

Who initializes the members of Window::dafo?

for(int a=0; a<dafo.get_compNUM_TOT(); a++)
    {
      mkLyBuLayout(a);   //   comp Number
    }

for(int a=0; a<dafo.get_compNUM_TOT(); a++)
    {
      mkLyBuLayout(a);   //   comp Number
    }

To copy to clipboard, switch view to plain text mode 

This code could cause the seg fault if get_compNUM_TOT returns an uninitialized int.

Regards

dafo's members are all static, initialized in dafo.cpp.

[marcel]

Well, it is pretty hard to see anything without debugging.
I recommend doing so in the constructor.

BTW: "EARTH Earth, the 3rd planet from the sun, is approximately four and a half billion years old.". I think it is older than that, but I'm sure this isn't causing the crash . The planet itself should be as old as the solar system.

EDIT: Oh, I read only half a billion years , missed the "four".
Anyway, I see you are on Windows, so debugging should be a lot easier. A step by step debugging should reveal the error.
Did it work before, when you were not using a singleton?


Regards

[vonCZ]

EDIT: Oh, I read only half a billion years , missed the "four".

though i live in CZ, I work for a geologic research institute in Texas... a state in which half the population believes the earth is only 6,000 years old. I've heard Jesus turned water into wine... I guess he turned rocks into oil, too.

[vonCZ]

So you should make the constructor private to prevent it from being accessed from any other class than Window.

oops- i didn't see this at first! Anyway, you were right on: I made the constructor private and changed changed a couple other things accordingly, i.e.

//--  main.cpp
 
  // Window window;  //changed to
  Window* window = Window::getInstance();

//--  main.cpp

  // Window window;  //changed to
  Window* window = Window::getInstance();

To copy to clipboard, switch view to plain text mode 

and it runs without crashing. For some reason

Window::getInstance()->getLabel()->setText("x")

still doesn't update the text, but i'll figure it out.

Thanks to all for your help...

[marcel]

oops- i didn't see this at first! Anyway, you were right on: I made the constructor private and changed changed a couple other things accordingly, i.e.

//--  main.cpp
 
  // Window window;  //changed to
  Window* window = Window::getInstance();

//--  main.cpp

  // Window window;  //changed to
  Window* window = Window::getInstance();

To copy to clipboard, switch view to plain text mode 

and it runs without crashing. For some reason

Window::getInstance()->getLabel()->setText("x")

still doesn't update the text, but i'll figure it out.

Thanks to all for your help...

This is is because you create 5 labels for each layer ( in mkZXag ). So, probably, the label you return is not the one which is visible.
The label you return in Window is the 7th.
Which layer do you have visible?

[vonCZ]

right again! ...this was just a test: the label "vuXLocLabel" will exist somewhere else--not on the zXag QStack or any other Stack--but I put it there just to test this out for convenience... by mistake (putting it on a stack).

huh- this was the cause of my original error, before I got into the Singleton stuff, i bet. Nevertheless, I'm glad ya'll helped me thru it: I still don't understand fully why, but I gather from this and other threads global variables--apparently even the kind I had coded in my original post--are a bad idea. I'll have to go back and re-do dafo.h/dafo.cpp using this singleton approach, I guess.

I'm still curious how this will work after I make the proper connections: for this test the QLabel is updated just once with a function call, but I'm going to created 3 QLabels that are updated by movement of the camera... ~25/sec. I'll be interested to see how making 3 getLabel()->setText("x/y/z") calls, 25/sec, works out.

[marcel]

I'm still curious how this will work after I make the proper connections: for this test the QLabel is updated just once with a function call, but I'm going to created 3 QLabels that are updated by movement of the camera... ~25/sec. I'll be interested to see how making 3 getLabel()->setText("x/y/z") calls, 25/sec, works out.

I wouldn't worry about that. There will be 25 function calls + signals/slots overhead.
There shouldn't be any problem with calling a function 25 times/second.

Eventually you could skip some of those values since no one can really see 25 coordinates/second anyway.

Regards

[wysota]

Do you by any chance use multiple threads in your application?

[vonCZ]

Do you by any chance use multiple threads in your application?

not intentionally ...i mean, no.