Some notes (mostly just my personal taste):
1. I can't do an out-of-source build (maybe a qmake limitation? - I know that it won't work on windows, but should work on linux)
2. usage() in src/qmake-HaiQ/qmake/option.cpp has too many '%s'
3. there are a lot of warnings about unused variables - is this intented?
4. You're using much "/" instead of '/' which should be much faster (no conversion from const char* to needed). The same with 'return ""' instead 'return QString()'
5. sometimes your function takes 'QString foo' instead 'const QString &foo')
6. you compare QStrings to "" instead use QString::isEmpty()
7. Do you programm with msvc6 because of this:
int j;
for (j=0; j<action_list.count(); j++)
int j;
for (j=0; j<action_list.count(); j++)
To copy to clipboard, switch view to plain text mode
which should imho be rewritten by this
for (int j=0; j<action_list.count(); j++)
for (int j=0; j<action_list.count(); j++)
To copy to clipboard, switch view to plain text mode
To avoid confusion
/edit: some more:
- The links in the about box do not work: "Der Befehl lässt sich nicht ausführen. Die Datei oder der Ordner file:///home/ehrlicher_c/tmp/HaiQ-0.2.6-3/www.trolltech.com existiert nicht."
- "make install" is not available
- Tools -> Configuration gives me those warnings: "Warning: QProcess: Destroyed while process is still running."
- imho is AStyle executable named 'astyle' on linux (and not AStyle)
Bookmarks