best threading solution?

[danics]

Hi,
first of all my question may be seemed too open, but i think its not ,

i want to read from a electronic device (from serial port) every 50-100 msec and i think i must added it to a thread i call it main thread, i parse readed data and if i have a good result show some message in my ui,
i have a menu form in my ui too, if user click every of buttons in ui, my main thread must block.
so this is what i want: if main thread run Ui block and if ui run main thread block. i have some messaging mechanism with signals and slots too,

so i must use wait conditions or you have another suggestions?? what you say?

my main thread each loop get only 1 second time for run and then can sleep 50 msec or set/release a wait conditon i dont know
i have another thread too if another two threads are block, and if its time of my tasks (like 2 times in hour) for downloading and uploading my results, this one must run but dont block their, priority of those is more than this thread and i must send this thread to sleep,
on another hand this thread only have 50-100 msec to run and then must go to sleep until main thread finish one loop work and go to sleep.
but downloading and uploading can run like that????

and my another question about this thread, how this one must be implemment? i mean use same mechanism probably but i must use a event loop for this thread am i right?
this is my download command

class DownloadCommand : public ICommand
{
    Q_OBJECT
public:
    DownloadCommand(QObject *parent = 0);
    DownloadCommand(const QString& url, QObject* parent=0);
 
    void setUrl(const QString& url) { m_url = QUrl(url); }
 
signals:
 
public slots:    
    void onNetworkReply(QNetworkReply* reply);
    void downloadCompleted(qint64 d, qint64 size);
    QString execute();
 
private:
    QUrl m_url;
    QString m_localpath;
    QNetworkAccessManager manager;
    QNetworkReply* m_reply;
};
 
DownloadCommand::DownloadCommand(QObject *parent) :
    ICommand(parent)
{
}
 
DownloadCommand::DownloadCommand(const QString &url, QObject *parent) : ICommand(parent)
{
    m_url = QUrl::fromUserInput(url);
}
 
QString DownloadCommand::execute()
{
    m_reply = manager.get(QNetworkRequest(m_url));
    connect(&manager, SIGNAL(finished(QNetworkReply*)), this, SLOT(onNetworkReply(QNetworkReply*)));
    connect(m_reply, SIGNAL(downloadProgress(qint64,qint64)), this, SLOT(downloadCompleted(qint64,qint64)));
    return tr("Download Started...");
}
 
void DownloadCommand::onNetworkReply(QNetworkReply *reply)
{
    if(reply->error() != QNetworkReply::NoError)
        return;
 
    QByteArray data = reply->readAll();
    if(data.length() < 2) return;
 
    QFileInfo fileInfo(m_url.path());
    QString fileName = fileInfo.fileName();
    if(fileName.isEmpty())
       fileName = "unknown.file";
 
    if(!m_localpath.isNull())
       fileName = m_localpath + QDir::separator() + fileName;
 
    if(QFile::exists(fileName))
    {
       int i = 0;
       QString newfileName = fileName + ".";
 
       while(QFile::exists(newfileName + QString::number(i)))
           ++i;
 
       newfileName += QString::number(i);
       QFile fm(fileName);
       fm.rename(newfileName);
    }
 
    QFile file(fileName);
    if(file.open(QFile::WriteOnly))
        file.write(data);
 
    reply->deleteLater();
    m_reply->deleteLater();
}
 
void DownloadCommand::downloadCompleted(qint64 d, qint64 size)
{
    if((d == 0 && size == 0) || (m_reply->error() != QNetworkReply::NoError))
        emit processFinished(tr("Cant download file error is %1").arg(m_reply->errorString()));
    else
    {
        if(size != -1)
            emit processChanges(100 * d / size);
        else emit processChanges(-1);
        if(size == d)
            emit processFinished(tr("Download is complete"));
    }
}

class DownloadCommand : public ICommand
{
    Q_OBJECT
public:
    DownloadCommand(QObject *parent = 0);
    DownloadCommand(const QString& url, QObject* parent=0);

    void setUrl(const QString& url) { m_url = QUrl(url); }
    
signals:
    
public slots:    
    void onNetworkReply(QNetworkReply* reply);
    void downloadCompleted(qint64 d, qint64 size);
    QString execute();

private:
    QUrl m_url;
    QString m_localpath;
    QNetworkAccessManager manager;
    QNetworkReply* m_reply;
};

DownloadCommand::DownloadCommand(QObject *parent) :
    ICommand(parent)
{
}

DownloadCommand::DownloadCommand(const QString &url, QObject *parent) : ICommand(parent)
{
    m_url = QUrl::fromUserInput(url);
}

QString DownloadCommand::execute()
{
    m_reply = manager.get(QNetworkRequest(m_url));
    connect(&manager, SIGNAL(finished(QNetworkReply*)), this, SLOT(onNetworkReply(QNetworkReply*)));
    connect(m_reply, SIGNAL(downloadProgress(qint64,qint64)), this, SLOT(downloadCompleted(qint64,qint64)));
    return tr("Download Started...");
}

void DownloadCommand::onNetworkReply(QNetworkReply *reply)
{
    if(reply->error() != QNetworkReply::NoError)
        return;

    QByteArray data = reply->readAll();
    if(data.length() < 2) return;

    QFileInfo fileInfo(m_url.path());
    QString fileName = fileInfo.fileName();
    if(fileName.isEmpty())
       fileName = "unknown.file";

    if(!m_localpath.isNull())
       fileName = m_localpath + QDir::separator() + fileName;

    if(QFile::exists(fileName))
    {
       int i = 0;
       QString newfileName = fileName + ".";

       while(QFile::exists(newfileName + QString::number(i)))
           ++i;

       newfileName += QString::number(i);
       QFile fm(fileName);
       fm.rename(newfileName);
    }

    QFile file(fileName);
    if(file.open(QFile::WriteOnly))
        file.write(data);

    reply->deleteLater();
    m_reply->deleteLater();
}

void DownloadCommand::downloadCompleted(qint64 d, qint64 size)
{
    if((d == 0 && size == 0) || (m_reply->error() != QNetworkReply::NoError))
        emit processFinished(tr("Cant download file error is %1").arg(m_reply->errorString()));
    else
    {
        if(size != -1)
            emit processChanges(100 * d / size);
        else emit processChanges(-1);
        if(size == d)
            emit processFinished(tr("Download is complete"));
    }
}

To copy to clipboard, switch view to plain text mode 

(i copy this code for dont say me give us some code man ) .)

so i think move it to MyThread and then run myThread.exec() every time that i need to download file. ( i ask this question for correct running signals and slots in thread)

thanks.

[wysota]

Use a timer instead of a thread.

[danics]

i use QTimer before but its get so cpu usage for 50 msec call, am i right? this program run on a embedded system

and how can i handle download thread?

[wysota]

If you use a thread it will also bump up your cpu usage. If you need to do something, it will have to be done by the cpu regardless if you use a thread or not.

[danics]

i dont mean that, i mean impletation of Qtimer for small intervals may be is not so good i dont remember where i read this so i ask,
and if i use a timer for my main loop how can i run a task thread for downloading and uploading my data?
you say a timer exactly run in its interval time and sleep other threads? ( i think timeout signal go to queue so my other threads can delay running main process)

[wysota]

i dont mean that, i mean impletation of Qtimer for small intervals may be is not so good i dont remember where i read this so i ask,

Ask the one who wrote it

and if i use a timer for my main loop how can i run a task thread for downloading and uploading my data?

You don't need a thread for that.

you say a timer exactly run in its interval time and sleep other threads?

The timer has no influence on other threads.

( i think timeout signal go to queue so my other threads can delay running main process)

Look, it is very simple -- if your program has to do two tasks which take 10 and 20 units of the processor time then regardless if you use threads or not, you will have to spend 30 units of processor time on those tasks. If your machine can do more tasks in parallel than there are tasks waiting to execute (e.g. the processor has multiple cores) then the real time used to complete both tasks (assuming they are independent) will take less than 30 units of time. If your machine has less concurrent threads than there are tasks to execute then the total amount of time spent will be more than those 30 units because the processor will need to switch between tasks. Considering the system has to do more than just handle your two-threaded application, it is very likely it has more tasks to do than threads available. In that case adding more and more threads will slow down the process rather than speeding it up.

[danics]

ok let me explain more, i want to know witch solution is better,
first of all i know i need 30 units, but i have priority for switch task, i need my main thread run with download thread somehow simultaneity but if sleep time of main thread finished the download thread must go to sleep and wait to up until main thread again finish, so in your explanation we cant send a signal to a thread to sleep and call another thread to run, we can do this right? and if you say yes, how much this process better than use timers (in timers mode probably main thread dont run until download thread finish)

we have a loop for main thread and we set a wait condition this is main loop

while(1) {
waitOn(); // check if Ui is in waiting state and if its not set uis and download to wait
doWork();
setOn() // set wait to free
sleep(100);
}

and our problem is download thread, its not run sync so i dont know how implement it?
and finally you dont say if i send my sample download command i a thread object and then call exec() function of that thread everything works in event loop of that thread right?

[wysota]

You don't need any "download thread". It's not that there is a dwarf sitting there and constantly pulling a string that has your incoming data attached to it and which needs constant bugging to get to work. When the data arrives into the socket you will be informed about it, you can read the data (which takes literally miliseconds) and afterwards you can attend to other tasks. When more data arrives, you will again be informed about it, you will read the data and go back to the other task. On the other hand if you do it with threads, your thread will sit around doing nothing 99% of the time and you will have a lot of trouble in synchronizing all your threads.

Your while() loop can be decomposed into a simple timer running with 100ms interval that triggers a slot that calls "doWork()".

Here, read this: [wiki]Keeping the GUI Responsive[/wiki]