exitCode problem in QProcess

[mattia]

Hello, i hava a problem with QProcess.
I made this connection:

connect ( myProcess , SIGNAL ( finished ( int , QProcess::ExitStatus ) ) , this , SLOT ( processVNCFinished ( int , QProcess::ExitStatus ) ) );

connect ( myProcess , SIGNAL ( finished ( int , QProcess::ExitStatus ) ) , this , SLOT ( processVNCFinished ( int , QProcess::ExitStatus ) ) );

To copy to clipboard, switch view to plain text mode 

so when the process finish i call the slot processVNCFinished.
This is my processVNCFinished slot:

void mainWindow::processVNCFinished ( int exitCode , QProcess::ExitStatus exitStatus )
{
	if ( exitStatus == QProcess::CrashExit )
	{
		qDebug () << "VNC client program crashed\n";
	}
	else if ( exitCode != 0 )
	{
		qDebug () << "VNC client program failed\n";
	}
	else
	{
		qDebug () << "VNC client program OK!\n";
	}
 
}

void mainWindow::processVNCFinished ( int exitCode , QProcess::ExitStatus exitStatus )
{
	if ( exitStatus == QProcess::CrashExit )
	{
		qDebug () << "VNC client program crashed\n";
	}
	else if ( exitCode != 0 )
	{
		qDebug () << "VNC client program failed\n";
	}
	else
	{
		qDebug () << "VNC client program OK!\n";
	}

}

To copy to clipboard, switch view to plain text mode 

i'm going to call vncviewer and when i close the vncviewer window clicking on the "X" on the right top window i get an exitCode = 1. Shouldn't i receive a 0 like exitCode?
In this way i always fall into qDebug () << "VNC client program failed\n" and instead i'd like to go into qDebug () << "VNC client program OK!\n".
Thx

[wysota]

This seems to be an issue with vncviewer and not Qt. Can you verify that vncviewer returns 0 when run from console?

[mattia]

what should i do to verify it?
thx

[wysota]

Call it from bash and use && and || to check if the result is 0 or not, for example:

$ vncviewer && echo "zero"

If you receive the text "zero", it means vncviewer returned 0.

$ vncviewer || echo "not zero"

This will check if it returns something else than 0.

[mattia]

echo works in this case:

$ vncviewer || echo "not zero"

so vnc doesn't return zero.
well, my code is ok, i have to catch when exitCode is 1? this means the vnc is close correctly?

[wysota]

I don't know if it is 1. It is "not 0". Can't you just rely on QProcess::ExitStatus?

[mattia]

mmm..i modified my code in this way:

void mainWindow::processVNCFinished ( int exitCode , QProcess::ExitStatus exitStatus )
      {
          if ( exitStatus == QProcess::CrashExit )
          {
              qDebug () << "VNC client program crashed\n";
          }
          else if ( exitCode != 0 && exitStatus != QProcess::NormalExit )
          {
              qDebug () << "VNC client program failed\n";
          }
          else
          {
              qDebug () << "VNC client program OK!\n";
          }
      }

void mainWindow::processVNCFinished ( int exitCode , QProcess::ExitStatus exitStatus )
      {
          if ( exitStatus == QProcess::CrashExit )
          {
              qDebug () << "VNC client program crashed\n";
          }
          else if ( exitCode != 0 && exitStatus != QProcess::NormalExit )
          {
              qDebug () << "VNC client program failed\n";
          }
          else
          {
              qDebug () << "VNC client program OK!\n";
          }
      }

To copy to clipboard, switch view to plain text mode 

now it works.

[wysota]

if(exitCode != 0 && exitStatus != QProcess::NormalExit)

if(exitCode != 0 && exitStatus != QProcess::NormalExit)

To copy to clipboard, switch view to plain text mode 

You will never enter this branch, because you already checked that exitStatus is QProcess::NormalExit, so the second part of this if will always be false.