[java] write and read from file a dictionary

[mickey]

Hello,
I have a class Dictionary with "Word" and its frequency into a document. I wrote to file all these informations as xml. I wrote the file using .write method eg: out.write("<dic>\r\n"); etc. Is this way to write XML good?
The file will be:

<dic>
  <word freq="0.000002"> Hello </word>
  //all word
</dic>

<dic>
  <word freq="0.000002"> Hello </word>
  //all word
</dic>

To copy to clipboard, switch view to plain text mode 

is it better do in this way: ??

<dic>
  <word> 
        Hello 
        <freq> 
             0.000002
        </freq>
   </word>
  //al word
</dic>

<dic>
  <word> 
        Hello 
        <freq> 
             0.000002
        </freq>
   </word>
  //al word
</dic>

To copy to clipboard, switch view to plain text mode 

What will be the better?
In the end I have to read it and fill my structures (basically my class Dictionary).
Furthermore: is all this approach ok?

thanks,

[caduel]

Such questions are hard to answer ;-)

The second variant allows you more flexibility if ever you should feel the need to add more details to the "freq".
The first is simpler, on the other hand. I'd go with the first one (attribute) here.

And, yes, generating xml in that way is perfectly ok - esp. for such trivial structures.
If you had some generic tree structure, you could of course write a generic "toXml" traversal function... but since you have nothing of the kind, you would save no work if you were to generate some intermediate structure first.

Maybe, if your attributes get more numerous, you might want to introduce some helper class (I am sure there exists something like that in the Java universe), and create a tag; call some addAttribute() methods and finally print that tag (maybe with a passed indentation or so).

Don't overdo it, though. Otherwise you end up coding a xml DOM. (And if you want to use one, just grab one of the existing ones.)

HTH