QSignalMapper and argument problems

[harmodrew]

And why are you not creating your id out of that two x y informations?

because the matrix of buttons is indexed with two integers...
even if I store the status of the buttons in a member of a QPushButton-derived object (and not in a dedicated integer matrix) , I have the problem of choosing the value that has to be assigned to a button depending on the selected tool...the "tool variable" (integer variable that stores the tool choosen by the user) cannot be included into the matrix of button. Infact it doesn't make sense to store the tool into the button matrix obect because they have no logical relationship between them...

[Lykurg]

because the matrix of buttons is indexed with two integers...

int x,y;
QString id = QString("%1-%2").arg(x).arg(y);
// in the slot:
int x, y;
QStringList tmp = id.split("-");
x = tmp.at(0).toInt();
y = tmp.at(1).toInt();

int x,y;
QString id = QString("%1-%2").arg(x).arg(y);
// in the slot:
int x, y;
QStringList tmp = id.split("-");
x = tmp.at(0).toInt();
y = tmp.at(1).toInt();

To copy to clipboard, switch view to plain text mode 

or you create a local

QHash< QString (id), QPair< int (x), int (y) > > mapping;

QHash< QString (id), QPair< int (x), int (y) > > mapping;

To copy to clipboard, switch view to plain text mode 

I have the problem of choosing the value that has to be assigned to a button depending on the selected tool...

but you can surely access that information from your slot! there must be a pointer in your class, beside how would you do it when creating the connection, if you have there access you also have it in your slot.

[harmodrew]

No, I cannot access to the tool object:

mymacros.h:

#ifndef MYMACROS_H
#define MYMACROS_H
 
#define WALL 3
#define ENTRY 2
#define EXIT 1
#define REMOVE 0
 
#endif // MYMACROS_H

#ifndef MYMACROS_H
#define MYMACROS_H

#define WALL 3
#define ENTRY 2
#define EXIT 1
#define REMOVE 0

#endif // MYMACROS_H

To copy to clipboard, switch view to plain text mode 

tool.h:

#ifndef TOOL_H
#define TOOL_H
#include <QObject>
 
class Tool : public QObject
{
    Q_OBJECT
    int Type;
 
public slots:
    void SetWall();
    void SetEntry();
    void SetExit();
    void SetRemove();
};
#endif // TOOL_H

#ifndef TOOL_H
#define TOOL_H
#include <QObject>

class Tool : public QObject
{
    Q_OBJECT
    int Type;

public slots:
    void SetWall();
    void SetEntry();
    void SetExit();
    void SetRemove();
};
#endif // TOOL_H

To copy to clipboard, switch view to plain text mode 

tool.cpp:

#include "tool.h"
#include "mymacros.h"
 
void Tool:: SetWall()
{
    Type = WALL;
}
 
void Tool :: SetEntry()
{
    Type = ENTRY;
}
 
void Tool::SetExit()
{
    Type = EXIT;
}
 
void Tool::SetRemove()
{
    Type = REMOVE;
}

#include "tool.h"
#include "mymacros.h"

void Tool:: SetWall()
{
    Type = WALL;
}

void Tool :: SetEntry()
{
    Type = ENTRY;
}

void Tool::SetExit()
{
    Type = EXIT;
}

void Tool::SetRemove()
{
    Type = REMOVE;
}

To copy to clipboard, switch view to plain text mode 

toolbar.h:

#ifndef TOOLBAR_H
#define TOOLBAR_H
#include <mainwindow.h>
 
void CreateToolBar(MainWindow* win, Tool *tool);
 
#endif // TOOLBAR_H

#ifndef TOOLBAR_H
#define TOOLBAR_H
#include <mainwindow.h>

void CreateToolBar(MainWindow* win, Tool *tool);

#endif // TOOLBAR_H

To copy to clipboard, switch view to plain text mode 

toolbar.cpp:

#include "toolbar.h"
#include "ui_mainwindow.h"
#include "tool.h"
 
void CreateToolBar(MainWindow *win, Tool *tool)
{
    QToolBar *ToolBar = new QToolBar("ToolBar");
 
    QAction *WallButton=new QAction(QIcon(QApplication::applicationDirPath().append("/img/Wall.bmp")),"Wall",win);
    QAction *EntryButton=new QAction(QIcon(QApplication::applicationDirPath().append("/img/Entry.bmp")),"Entry",win);
    QAction *ExitButton=new QAction(QIcon(QApplication::applicationDirPath().append("/img/Exit.bmp")),"Exit",win);
    QAction *RemoveButton=new QAction(QIcon(QApplication::applicationDirPath().append("/img/Remove.bmp")),"Remove",win);
 
    ToolBar->insertAction(EntryButton,WallButton);
    ToolBar->insertAction(ExitButton,EntryButton);
    ToolBar->insertAction(RemoveButton,ExitButton);
    ToolBar->insertAction(0,RemoveButton);
 
    win->addToolBar(ToolBar);
 
// here I connect the buttons of the toolbar with the tool SLOTs (which change its status)
    win->connect(WallButton,SIGNAL(triggered()),tool, SLOT(SetWall()));
    win->connect(RemoveButton,SIGNAL(triggered()),tool, SLOT(SetRemove()));
    win->connect(ExitButton,SIGNAL(triggered()),tool, SLOT(SetExit()));
    win->connect(EntryButton,SIGNAL(triggered()),tool, SLOT(SetEntry()));
}

#include "toolbar.h"
#include "ui_mainwindow.h"
#include "tool.h"

void CreateToolBar(MainWindow *win, Tool *tool)
{
    QToolBar *ToolBar = new QToolBar("ToolBar");

    QAction *WallButton=new QAction(QIcon(QApplication::applicationDirPath().append("/img/Wall.bmp")),"Wall",win);
    QAction *EntryButton=new QAction(QIcon(QApplication::applicationDirPath().append("/img/Entry.bmp")),"Entry",win);
    QAction *ExitButton=new QAction(QIcon(QApplication::applicationDirPath().append("/img/Exit.bmp")),"Exit",win);
    QAction *RemoveButton=new QAction(QIcon(QApplication::applicationDirPath().append("/img/Remove.bmp")),"Remove",win);

    ToolBar->insertAction(EntryButton,WallButton);
    ToolBar->insertAction(ExitButton,EntryButton);
    ToolBar->insertAction(RemoveButton,ExitButton);
    ToolBar->insertAction(0,RemoveButton);

    win->addToolBar(ToolBar);

// here I connect the buttons of the toolbar with the tool SLOTs (which change its status)
    win->connect(WallButton,SIGNAL(triggered()),tool, SLOT(SetWall()));
    win->connect(RemoveButton,SIGNAL(triggered()),tool, SLOT(SetRemove()));
    win->connect(ExitButton,SIGNAL(triggered()),tool, SLOT(SetExit()));
    win->connect(EntryButton,SIGNAL(triggered()),tool, SLOT(SetEntry()));
}

To copy to clipboard, switch view to plain text mode 

so when the user chooses a button on the toolbar the status is stored in the integer member of Tool.
moreover in the mainwindow constructor I create a tool object which is passed to CreateToolbar to associate the toolbar buttons to the tool SLOTs:

part of the main.cpp:

//...
Tool *tool = new Tool;
MainWindow w(tool);
//...

//...
Tool *tool = new Tool;
MainWindow w(tool);
//...

To copy to clipboard, switch view to plain text mode 

mainwindowcpp:

#include "mainwindow.h"
#include "ui_mainwindow.h"
#include "toolbar.h"
#include "tool.h"
 
//MainWindow constructor
MainWindow::MainWindow(Tool *tool, QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::MainWindow)
{
    ui->setupUi(this);
    CreateToolBar(this, tool);
}
 
MainWindow::~MainWindow()
{
    delete ui;
}

#include "mainwindow.h"
#include "ui_mainwindow.h"
#include "toolbar.h"
#include "tool.h"

//MainWindow constructor
MainWindow::MainWindow(Tool *tool, QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::MainWindow)
{
    ui->setupUi(this);
    CreateToolBar(this, tool);
}

MainWindow::~MainWindow()
{
    delete ui;
}

To copy to clipboard, switch view to plain text mode 

so the tool is declared in the main and is accessible only in the MainWindow constructor, not in the ButtonMatrix object (which is declared in the main)

[Lykurg]

Ehm, you really should reconsider your design...
A simple hack:

// in MainWindow add a private variable
Tool *m_tool;
 
//MainWindow constructor
MainWindow::MainWindow(Tool *tool, QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::MainWindow)
{
    ui->setupUi(this);
    CreateToolBar(this, tool);
    m_tool = tool; // add this
}

// in MainWindow add a private variable
Tool *m_tool;

//MainWindow constructor
MainWindow::MainWindow(Tool *tool, QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::MainWindow)
{
    ui->setupUi(this);
    CreateToolBar(this, tool);
    m_tool = tool; // add this
}

To copy to clipboard, switch view to plain text mode 

now you can access tool via m_tool in your main window. (BUT that is really no good design!!!)

[harmodrew]

ok, I'll take a look to the design (I was doing it right now)
thanks

[harmodrew]

I've changed something in my code. Now the mainwindow class is:

mainwindow.h
#ifndef MAINWINDOW_H
#define MAINWINDOW_H
 
#include <QMainWindow>
#include <QPushButton>
#include "tool.h"
#include "buttonmatrix.h"
#include <QString>
 
namespace Ui {
    class MainWindow;
}
 
class MainWindow : public QMainWindow
{
    Q_OBJECT
private:
    Ui::MainWindow *ui;
    Tool *tool;
    ButtonMatrix *buttonMatrix;
    QToolBar *toolBar;
    QString PathToIcons;
 
public:
    explicit MainWindow(int inputnr, int inputnc, QString path_to_icons,QWidget *parent = 0);
    ~MainWindow();
    void CreateToolBar();
    void CreateButtonMatrix(int nrow, int ncol);
    void InstanceTool();
public slots:
    void SetMatrixItem(const QString & ID);
};

mainwindow.h
#ifndef MAINWINDOW_H
#define MAINWINDOW_H

#include <QMainWindow>
#include <QPushButton>
#include "tool.h"
#include "buttonmatrix.h"
#include <QString>

namespace Ui {
    class MainWindow;
}

class MainWindow : public QMainWindow
{
    Q_OBJECT
private:
    Ui::MainWindow *ui;
    Tool *tool;
    ButtonMatrix *buttonMatrix;
    QToolBar *toolBar;
    QString PathToIcons;

public:
    explicit MainWindow(int inputnr, int inputnc, QString path_to_icons,QWidget *parent = 0);
    ~MainWindow();
    void CreateToolBar();
    void CreateButtonMatrix(int nrow, int ncol);
    void InstanceTool();
public slots:
    void SetMatrixItem(const QString & ID);
};

To copy to clipboard, switch view to plain text mode 

now I have to set properly the buttons parent which should be the window. I'd make it in che ButtonMatrix constructor (buttons is the pointer to the QPushButton matrix)

ButtonMatrix::ButtonMatrix(QWidget *win, int nr, int nc)
{
//...
    for (int i=0; i<nrow; i++)
    {
        for (int j=0; j<ncol; j++)
        {
//... 
            buttons[i][j].setParent(win);   // <---
//...
        }
    }
//...
}

ButtonMatrix::ButtonMatrix(QWidget *win, int nr, int nc)
{
//...
    for (int i=0; i<nrow; i++)
    {
        for (int j=0; j<ncol; j++)
        {
//... 
            buttons[i][j].setParent(win);   // <---
//...
        }
    }
//...
}

To copy to clipboard, switch view to plain text mode 

commenting this row the buttons are shown each in a single window, indipendent from the mainwindow. while, if I uncomment the row the matrix is shown but, when I close the program, I gain a program crash (tre program doesn't quit properly)...

[squidge]

How are you creating your matrix?

Actually, looking at your header file, why do you have a method called CreateButtonMatrix (with the name stating it creates a matrix) but takes a row and column parameter? From the parameter list it seems it (confusingly) creates a single button, not a matrix?

[harmodrew]

one of the members of MainWindow is, as you see, a ButtonMatrix pointer. the ButtonMatrix object is declared as follows:
buttonmatrix.h:

#ifndef BUTTONMATRIX_H
#define BUTTONMATRIX_H
 
#include <QPushButton>
#include <QSignalMapper>
#include <QString>
#include <QObject>
 
class ButtonMatrix : public QObject
{
    Q_OBJECT
private:
    QPushButton **buttons; // this is private so out of the ButtonMatrix object it is not accessible
    int **status;
    int nrow;
    int ncol;
    QSignalMapper *signalMapper;
public:
    ButtonMatrix(){}
    ButtonMatrix(QWidget* win, int nrow, int ncol);
    ~ButtonMatrix();
    void Show();
    void SetNRow(int nr);
    void SetNCol(int nc);
    void GenerateMatrix();
    void SetBackground(int i, int j, QString aux);
};
 
 
#endif // BUTTONMATRIX_H

#ifndef BUTTONMATRIX_H
#define BUTTONMATRIX_H

#include <QPushButton>
#include <QSignalMapper>
#include <QString>
#include <QObject>

class ButtonMatrix : public QObject
{
    Q_OBJECT
private:
    QPushButton **buttons; // this is private so out of the ButtonMatrix object it is not accessible
    int **status;
    int nrow;
    int ncol;
    QSignalMapper *signalMapper;
public:
    ButtonMatrix(){}
    ButtonMatrix(QWidget* win, int nrow, int ncol);
    ~ButtonMatrix();
    void Show();
    void SetNRow(int nr);
    void SetNCol(int nc);
    void GenerateMatrix();
    void SetBackground(int i, int j, QString aux);
};


#endif // BUTTONMATRIX_H

To copy to clipboard, switch view to plain text mode 

as commented in the code, the ButtonMatrix object has a member pointer which points the QPushButton matrix in the heap. of course all methods of the ButtonMatrix object can access the buttons pointer. From a MainWindow method I cannot access directly the buttons pointer but only the private ButtonMatrix object. So I need a function of ButtonMatrix which can be called from MainWindow to setup the buttons pointer:

void MainWindow::CreateButtonMatrix(int nrow, int ncol)
{
    buttonMatrix->SetNRow(nrow);
    buttonMatrix->SetNCol(ncol);
    buttonMatrix->GenerateMatrix();
}

void MainWindow::CreateButtonMatrix(int nrow, int ncol)
{
    buttonMatrix->SetNRow(nrow);
    buttonMatrix->SetNCol(ncol);
    buttonMatrix->GenerateMatrix();
}

To copy to clipboard, switch view to plain text mode 

GenerateMatrix uses previously setted ncol and nrow to instance buttons and status pointers of the ButtonMatrix object:

void ButtonMatrix::GenerateMatrix()
{
    buttons = new QPushButton*[nrow];
    status = new int*[nrow];
    for (int i=0; i<nrow; i++)
    {
        buttons[i] = new QPushButton[ncol];
        status[i] = new int[ncol];
    }
 
}

void ButtonMatrix::GenerateMatrix()
{
    buttons = new QPushButton*[nrow];
    status = new int*[nrow];
    for (int i=0; i<nrow; i++)
    {
        buttons[i] = new QPushButton[ncol];
        status[i] = new int[ncol];
    }

}

To copy to clipboard, switch view to plain text mode 

[harmodrew]

The error comes up even if i pass to the ButtonMatrix constructor a frame instead of the mainwindow...