Can somebody show how to read bytes?

["BumbleBee"]

int size = f.size();
 
             QByteArray bytes = f.readAll();
 
             qDebug() << bytes; //outputs ""MZP
 
             qDebug() << bytes.toHex(); //Same output :(

int size = f.size();

             QByteArray bytes = f.readAll();
            
             qDebug() << bytes; //outputs ""MZP

             qDebug() << bytes.toHex(); //Same output :(

To copy to clipboard, switch view to plain text mode 

[mcosta]

What do you expect to read??

You're reading a binary file!

["BumbleBee"]

What do you mean?

I want to convert that to hex...

[mcosta]

For me this code

char data [] = { 0xaa, 0x01, 0x00, 0xFF, 0xBA};
    QByteArray ba (data, 5);
 
    qDebug() << ba;
    qDebug() << ba.toHex();

char data [] = { 0xaa, 0x01, 0x00, 0xFF, 0xBA};
    QByteArray ba (data, 5);

    qDebug() << ba;
    qDebug() << ba.toHex();

To copy to clipboard, switch view to plain text mode 

print

"ª

"aa0100ffba"

"ª

"aa0100ffba"

To copy to clipboard, switch view to plain text mode 

["BumbleBee"]

How is this related to my source?
i get MZP when reading Anscii like wysota said.
But Chris said I have to convert that QBA to hex..which doesn't work...

[wysota]

But Chris said I have to convert that QBA to hex..which doesn't work...

What doesn't work? What's the point of dumping the whole file to the screen in its hexadecimal form?

#include <QFile>
#include <stdio.h>
 
int main(int argc, char **argv) {
  QFile f(argv[1]);
  f.open(QFile::ReadOnly);
  int offset = 0;
  while(!f.atEnd()){
      QByteArray ba = f.read(16).toHex();
      QString offsetStr = QString::number(offset, 16);
      while(offsetStr.size()<8) offsetStr.prepend('0');
      printf("0x%s\t", qPrintable(offsetStr));
      offset+=16;
 
      for(int i=ba.size()-2;i>0;i-=2) {
	ba.insert(i, ' ');
      }
 
      printf("%s\n", ba.constData());
  }
  return 0;
}

#include <QFile>
#include <stdio.h>

int main(int argc, char **argv) {
  QFile f(argv[1]);
  f.open(QFile::ReadOnly);
  int offset = 0;
  while(!f.atEnd()){
      QByteArray ba = f.read(16).toHex();
      QString offsetStr = QString::number(offset, 16);
      while(offsetStr.size()<8) offsetStr.prepend('0');
      printf("0x%s\t", qPrintable(offsetStr));
      offset+=16;
      
      for(int i=ba.size()-2;i>0;i-=2) {
	ba.insert(i, ' ');
      }
      
      printf("%s\n", ba.constData());
  }
  return 0;
}

To copy to clipboard, switch view to plain text mode 

["BumbleBee"]

What doesn't work? What's the point of dumping the whole file to the screen in its hexadecimal form?

#include <QFile>
#include <stdio.h>
 
int main(int argc, char **argv) {
  QFile f(argv[1]);
  f.open(QFile::ReadOnly);
  int offset = 0;
  while(!f.atEnd()){
      QByteArray ba = f.read(16).toHex();
      QString offsetStr = QString::number(offset, 16);
      while(offsetStr.size()<8) offsetStr.prepend('0');
      printf("0x%s\t", qPrintable(offsetStr));
      offset+=16;
 
      for(int i=ba.size()-2;i>0;i-=2) {
	ba.insert(i, ' ');
      }
 
      printf("%s\n", ba.constData());
  }
  return 0;
}

#include <QFile>
#include <stdio.h>

int main(int argc, char **argv) {
  QFile f(argv[1]);
  f.open(QFile::ReadOnly);
  int offset = 0;
  while(!f.atEnd()){
      QByteArray ba = f.read(16).toHex();
      QString offsetStr = QString::number(offset, 16);
      while(offsetStr.size()<8) offsetStr.prepend('0');
      printf("0x%s\t", qPrintable(offsetStr));
      offset+=16;
      
      for(int i=ba.size()-2;i>0;i-=2) {
	ba.insert(i, ' ');
      }
      
      printf("%s\n", ba.constData());
  }
  return 0;
}

To copy to clipboard, switch view to plain text mode 

I need to take the hex,in order to encrypt it and save it as a new exe...btw,your code makes an infinite loop....

[FelixB]

.btw,your code makes an infinite loop....

where is that infinite loop? I don't see any...

["BumbleBee"]

#include "StdAfx.h"
#include <iostream>
#include <string.h>
using namespace std;
 
void encrypt_data();
 
int main()
{
FILE * f;
unsigned char buffer[100];
int n;
 
f = fopen("C:\\Program Files (x86)\\TeamViewer\\Version6\\TeamViewer.exe", "rb");
if (f)
{
    n = fread(buffer, 100, 1, f);
for (int c = 0; c <= 100 ; c++)
{
     printf("%.2X ", (int)buffer[c]); //outputs hex!!!!!!
     // put an extra space between every 4 bytes
     if (c % 4 == 3)
     {
         printf(" ");
     }
 
     // Display 16 bytes per line
     if (c % 16 == 15)
     {
         printf("\n");
     }
}
// Add an extra line feed for good measure
printf("\n\n\n");
}
else
{
    cout << "error";
}
 
char a;
	cin >> a;
	return 0;
}

#include "StdAfx.h"
#include <iostream>
#include <string.h>
using namespace std;

void encrypt_data();

int main()
{
FILE * f;
unsigned char buffer[100];
int n;

f = fopen("C:\\Program Files (x86)\\TeamViewer\\Version6\\TeamViewer.exe", "rb");
if (f)
{
    n = fread(buffer, 100, 1, f);
for (int c = 0; c <= 100 ; c++)
{
     printf("%.2X ", (int)buffer[c]); //outputs hex!!!!!!
     // put an extra space between every 4 bytes
     if (c % 4 == 3)
     {
         printf(" ");
     }

     // Display 16 bytes per line
     if (c % 16 == 15)
     {
         printf("\n");
     }
}
// Add an extra line feed for good measure
printf("\n\n\n");
}
else
{
    cout << "error";
}

char a;
	cin >> a;
	return 0;
}

To copy to clipboard, switch view to plain text mode 

I want to make that in Qt^^^

And FelixB the loop doesn't stop for me.

[FelixB]

And FelixB the loop doesn't stop for me.

which loop do you mean?

["BumbleBee"]

it keeps outputting bytes....never stops.

[wysota]

it keeps outputting bytes....never stops.

Maybe try pointing the program to a smaller file?

[wysota]

btw,your code makes an infinite loop....

There is no infinite loop in my code.

[squidge]

I need to take the hex,in order to encrypt it and save it as a new exe...btw,your code makes an infinite loop....

Why do you want to encrypt the hex (text) version of a binary file? Why not just encrypt the binary version? Converting to text first makes no sense...

[wysota]

Maybe he wants to encrypt twice as much as he needs to? It's always fun to make a 10MB file out of a 5MB file...

["BumbleBee"]

Why do you want to encrypt the hex (text) version of a binary file? Why not just encrypt the binary version? Converting to text first makes no sense...

You mean like this?

QByteArray byte = file.read(16);

QByteArray byte = file.read(16);

To copy to clipboard, switch view to plain text mode 

[squidge]

You mean like this?

QByteArray byte = file.read(16);

QByteArray byte = file.read(16);

To copy to clipboard, switch view to plain text mode 

Yes, exactlly.

["BumbleBee"]

This outputs some strange symbols(I suppose bin. code),but it also beeps and crashes after some secs...

[wysota]

Do you want to encrypt it or print it? I doubt encrypting it outputs any strange symbols or makes any sounds. This is binary data that is not suitable for printing to a text terminal.

[mcosta]

Why doesn't work?

This code

void Widget::on_openFileButton_clicked()
{
    QString fileName = QFileDialog::getOpenFileName (
                this,
                tr ("Open File"),
                ".",
                tr ("Executable files (*exe)"));
 
    if (!fileName.isEmpty ()) {
        QFile f (fileName);
 
        const int SIZE = 100;
        int readSize;
 
        f.open (QIODevice::ReadOnly);
        readSize = (f.size () > SIZE)? SIZE: f.size ();
 
        QByteArray ba = f.read (readSize);
 
        ui->rawDataEdit->setPlainText (ba);
        ui->hexDataEdit->setPlainText (ba.toHex ());
    }
}

void Widget::on_openFileButton_clicked()
{
    QString fileName = QFileDialog::getOpenFileName (
                this,
                tr ("Open File"),
                ".",
                tr ("Executable files (*exe)"));

    if (!fileName.isEmpty ()) {
        QFile f (fileName);

        const int SIZE = 100;
        int readSize;

        f.open (QIODevice::ReadOnly);
        readSize = (f.size () > SIZE)? SIZE: f.size ();

        QByteArray ba = f.read (readSize);

        ui->rawDataEdit->setPlainText (ba);
        ui->hexDataEdit->setPlainText (ba.toHex ());
    }
}

To copy to clipboard, switch view to plain text mode 

shows this output when I select a EXE file

imagine1.JPG