QCodeEdit

[fullmetalcoder]

I've corrected all the reported issues so far (or so I believe...)and taken the opportunity to improve the example app a bit.

I'm waiting for your feedback

[Usability]

I've corrected all the reported issues so far (or so I believe...)and taken the opportunity to improve the example app a bit.

I'm waiting for your feedback

Thank you, everything looks good.

Folding works as you say, thanks for the begin/end advice that fixes my problem here.
I see find in selection working, and from cursor now the default.
The crash on reload fixed.

So back to no known defects Cool.

[Usability]

Hi Fullmetalcoder.

I gave a program containing this editor to a college for comments, and got this feedback.

I'm really getting used to using this editor and growing more fond of it as the days go by, but there are a couple of minor suggestions/irritations:

1) When scrolling up when the cursor moves up from the top line of the screen it causes an extra line to appear - when scrolling down and the cursor hits the bottom of the screen the next down causes the next page to appear and the cursor is now at the top of this screen. This is extremely irritating!

2) When using find - what does the green button to the left of the string entry box do? When I click it it appears to do nothing.

3) There is a tooltip on the close button for the find toolbar, but not on the "green" button or the find forward/reverse buttons

4) When using the find forward button and then use the find reverse the first hit does not move onto the next match (the line number stays the same, but the column numbers change). The same is true when doing the reverse.

5) If you do a forward find and then move the cursor to a line above the found string, then hit find forward again it goes to the next match (I would expect that because the line with the cursor is highlighted that the previous match would be highlighted again)

[Usability]

Just noticed, prompted find/replace is broken. For example,
example/example lib/qcodeedit.cpp

Key ctrl-r, try and replace this with that. The settings I had were, match case, prompt on replace, from cursor.
I get a box asking "Shall it be replaced?" Clicking yes has no effect (other than to close the QMessageBox).

[Usability]

Following up my own post because I noticed the replacement IS made if you answer "No" to the "Shall it be replaced?" question....

[Usability]

I find scrolling the editor sometimes makes it lock up when using proportional fonts.

Here is a way that reproduces the problem every time on my machine at least.

Change the example to use a proportional font by adding after line 47 of example/window.cpp this line
m_editControl->editor()->document()->setFont(font());
rebuild the example, then do this

example/example lib/qeditor.cpp

Scroll to the bottom by holding down the page down key. When you get to the bottom, scroll back to the top holding down page up. When the editor returns to the top, it should have locked up.

[fullmetalcoder]

I gave a program containing this editor to a college for comments, and got this feedback.

Neat!

1. I'm not sure I understand this... Could you provide me with a screencast or a precise key sequence leading to this bug
2. It is supposed to "refresh" the search context (see the QDocumentSearch class) but I guess I could remove it and use a couple signals/slots to make sure it (the search context remains up to date)
3. There should be a tooltip on *all* buttons since the last commit
4. I'm aware of that and I'll work on a proper fix ASAP
5. This is a case where the "green button" should prove useful (but a proper signal/slot connection would probably be better... )
6. About the wrong replacement behavior it will be pretty easy to fix (qdocumentsearch.cpp there is only one call to QMessageBox)
7. I'll try to reproduce this (and fix it hopefully) ASAP

[Usability]

To clarify point 1. Try using the up/down cursor keys to move the cursor up and down the screen. When you use the down cursor to move to the next line, and you are already on the last line displayed, the editor jumps a complete screen full down the file.

This is different behaviour than we see with the up cursor. If you move up when you are at the top line displayed, the editor scrolls the viewport up one line to keep the line containing the cursor at the top of the screen.

We prefer the behaviour of the editor when the text cursor is moved up through the file, and hope you agree and will standardise on that. Certainly up and down should scroll in a consistant way.